Bug 100658 - [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
Summary: [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThread...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 05:28 PDT by jochen
Modified: 2012-10-29 23:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.42 KB, patch)
2012-10-29 05:30 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2012-10-29 22:22 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-10-29 05:28:33 PDT 
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
Comment 1 jochen 2012-10-29 05:30:11 PDT 
Created attachment 171209 [details]
Patch
Comment 2 Tony Chang 2012-10-29 11:18:15 PDT 
Comment on attachment 171209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171209&action=review

> Tools/ChangeLog:10
> +        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

You can add extra notes about the code change here.  For example, it would have been helpful if you wrote that include_dirs and dependencies is redundant here because TestRunner already has these settings.
Comment 3 jochen 2012-10-29 22:22:18 PDT 
Created attachment 171373 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-29 23:44:02 PDT 
Comment on attachment 171373 [details]
Patch

Clearing flags on attachment: 171373

Committed r132872: <http://trac.webkit.org/changeset/132872>
Comment 5 WebKit Review Bot 2012-10-29 23:44:06 PDT 
All reviewed patches have been landed.  Closing bug.