WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100658
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
https://bugs.webkit.org/show_bug.cgi?id=100658
Summary
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThread...
jochen
Reported
2012-10-29 05:28:33 PDT
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
Attachments
Patch
(2.42 KB, patch)
2012-10-29 05:30 PDT
,
jochen
no flags
Details
Formatted Diff
Diff
Patch
(2.51 KB, patch)
2012-10-29 22:22 PDT
,
jochen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
jochen
Comment 1
2012-10-29 05:30:11 PDT
Created
attachment 171209
[details]
Patch
Tony Chang
Comment 2
2012-10-29 11:18:15 PDT
Comment on
attachment 171209
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=171209&action=review
> Tools/ChangeLog:10 > + * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
You can add extra notes about the code change here. For example, it would have been helpful if you wrote that include_dirs and dependencies is redundant here because TestRunner already has these settings.
jochen
Comment 3
2012-10-29 22:22:18 PDT
Created
attachment 171373
[details]
Patch
WebKit Review Bot
Comment 4
2012-10-29 23:44:02 PDT
Comment on
attachment 171373
[details]
Patch Clearing flags on attachment: 171373 Committed
r132872
: <
http://trac.webkit.org/changeset/132872
>
WebKit Review Bot
Comment 5
2012-10-29 23:44:06 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug