Bug 100656 – Web Inspector: Implement native memory snapshot grid view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexei Filippov]

Show native memory snapshot in a grid view.

[Alexei Filippov]

Created attachment 171205 [details]
screenshot

[Alexei Filippov]

Created attachment 171206 [details]
Patch

[Alexei Filippov]

Created attachment 171213 [details]
screenshot with expanded items

[Alexei Filippov]

Created attachment 171221 [details]
screenshot. separate size column + odd-even striped grid

[Alexei Filippov]

Created attachment 171222 [details]
Patch

[Yury Semikhatsky]

Let's move Inspector data and Other sections to the bottom of the list?

[Alexei Filippov]

Created attachment 171228 [details]
screenshot: sorted top level + shifted bars

I don't like shifted bars!

[Alexei Filippov]

Created attachment 171230 [details]
Patch

[Alexei Filippov]

Created attachment 171231 [details]
screenshot: no bar shifts

[Alexei Filippov]

Created attachment 171236 [details]
Patch

[Yury Semikhatsky]

View in context: https://bugs.webkit.org/attachment.cgi?id=171230&action=review

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:53
> + * @param {MemoryAgent.MemoryBlock} snapshot

snapshot -> profile

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:60
> +        bar: { title: WebInspector.UIString("Bar"), sortable: false },

Can we merge bar column into size ?

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:81
> +    var sizeString = Number.withThousandsSeparator((this._nodeData.size / 1024).toFixed(0)) + "\u2009" + WebInspector.UIString("KiB");

Please use Number.bytesToString

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:110
> +        var maxBarLength = 700;

Why not full available table width?

[Alexei Filippov]

Created attachment 171239 [details]
screenshot: no bar column title

[Alexei Filippov]

Created attachment 171260 [details]
Patch

[Alexei Filippov]

(In reply to comment #11)
> View in context: https://bugs.webkit.org/attachment.cgi?id=171230&action=review
> 
> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:53
> > + * @param {MemoryAgent.MemoryBlock} snapshot
> 
> snapshot -> profile

fixed.

> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:60
> > +        bar: { title: WebInspector.UIString("Bar"), sortable: false },
> 
> Can we merge bar column into size ?

done.

> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:81
> > +    var sizeString = Number.withThousandsSeparator((this._nodeData.size / 1024).toFixed(0)) + "\u2009" + WebInspector.UIString("KiB");
> 
> Please use Number.bytesToString

I'm strongly against it. It makes the size value hardly readable.

> > Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:110
> > +        var maxBarLength = 700;
> 
> Why not full available table width?

done.

[Alexei Filippov]

Created attachment 171268 [details]
screenshot

[Yury Semikhatsky]

(In reply to comment #15)
> Created an attachment (id=171268) [details]
> screenshot

I'm not a fan of having the sizes aligned by the right side but I think we can fix this in the next iteration.

[WebKit Review Bot]

Comment on attachment 171260 [details]
Patch

Clearing flags on attachment: 171260

Committed r132888: <http://trac.webkit.org/changeset/132888>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

How does color coding work here? I don’t have to open a different panel to know that.

Aligning numbers to the right is generally a good practice.
http://blog.editage.com/Aligning-Columns