Bug 100642 - [EFL][DRT] Bitmap should show whole view area.
Summary: [EFL][DRT] Bitmap should show whole view area.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on: 95182
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-29 02:04 PDT by Kangil Han
Modified: 2012-10-30 02:40 PDT (History)
7 users (show)

See Also:


Attachments
patch (4.30 KB, patch)
2012-10-29 02:11 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
patch (8.85 KB, patch)
2012-10-29 22:14 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
patch (8.85 KB, patch)
2012-10-29 22:20 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-10-29 02:04:40 PDT
css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
Comment 1 Kangil Han 2012-10-29 02:11:40 PDT
Created attachment 171180 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-29 02:26:38 PDT
Comment on attachment 171180 [details]
patch

What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?
Comment 3 Kangil Han 2012-10-29 02:42:33 PDT
(In reply to comment #2)
> What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? 

(100, 100, 800, 600)

>How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?

Would you please elaborate this comment more?
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-29 05:12:30 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? 
> 
> (100, 100, 800, 600)

Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT?

> >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?
> 
> Would you please elaborate this comment more?

See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.
Comment 5 Kangil Han 2012-10-29 22:14:37 PDT
Created attachment 171371 [details]
patch
Comment 6 Kangil Han 2012-10-29 22:16:30 PDT
(In reply to comment #4)
> Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT?

Yes, it is. ;)

> See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.

Done. :)
Comment 7 WebKit Review Bot 2012-10-29 22:17:24 PDT
Attachment 171371 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Kangil Han 2012-10-29 22:20:10 PDT
Created attachment 171372 [details]
patch

Fix style error. :P
Comment 9 Raphael Kubo da Costa (:rakuco) 2012-10-30 02:05:19 PDT
Looks good, thanks!
Comment 10 WebKit Review Bot 2012-10-30 02:40:24 PDT
Comment on attachment 171372 [details]
patch

Clearing flags on attachment: 171372

Committed r132885: <http://trac.webkit.org/changeset/132885>
Comment 11 WebKit Review Bot 2012-10-30 02:40:29 PDT
All reviewed patches have been landed.  Closing bug.