Bug 100642 – [EFL][DRT] Bitmap should show whole view area.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Kangil Han]

css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.

[Kangil Han]

Created attachment 171180 [details]
patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 171180 [details]
patch

What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?

[Kangil Han]

(In reply to comment #2)
> What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? 

(100, 100, 800, 600)

>How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?

Would you please elaborate this comment more?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #3)
> (In reply to comment #2)
> > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? 
> 
> (100, 100, 800, 600)

Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT?

> >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?
> 
> Would you please elaborate this comment more?

See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.

[Kangil Han]

Created attachment 171371 [details]
patch

[Kangil Han]

(In reply to comment #4)
> Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT?

Yes, it is. ;)

> See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.

Done. :)

[WebKit Review Bot]

Attachment 171371 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp:50:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kangil Han]

Created attachment 171372 [details]
patch

Fix style error. :P

[Raphael Kubo da Costa (:rakuco)]

Looks good, thanks!

[WebKit Review Bot]

Comment on attachment 171372 [details]
patch

Clearing flags on attachment: 171372

Committed r132885: <http://trac.webkit.org/changeset/132885>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.