css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
Created attachment 171180 [details] patch
Comment on attachment 171180 [details] patch What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600?
(In reply to comment #2) > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? (100, 100, 800, 600) >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600? Would you please elaborate this comment more?
(In reply to comment #3) > (In reply to comment #2) > > What was the size of the rectangle returned by ewk_frame_visible_content_geometry_get() for these test cases? > > (100, 100, 800, 600) Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT? > >How about the tests in svg/W3C-SVG-1.1, for which we use a different window size than 800x600? > > Would you please elaborate this comment more? See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image.
Created attachment 171371 [details] patch
(In reply to comment #4) > Hmm, is this why some other pixel tests (see bug 99072) fail to generate the right images with DRT? Yes, it is. ;) > See <http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp#L274>: we create a smaller canvas for these tests, so my question is whether there's going to be any sort of regression since you now always create a 800x600 image. Done. :)
Attachment 171371 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp:50: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 171372 [details] patch Fix style error. :P
Looks good, thanks!
Comment on attachment 171372 [details] patch Clearing flags on attachment: 171372 Committed r132885: <http://trac.webkit.org/changeset/132885>
All reviewed patches have been landed. Closing bug.