RESOLVED FIXED 100627
Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h} 
https://bugs.webkit.org/show_bug.cgi?id=100627
Summary Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
Kent Tamura
Reported 2012-10-28 21:48:55 PDT
without class name change.
Attachments
Patch (60.58 KB, patch)
2012-10-28 22:20 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (62.59 KB, patch)
2012-10-28 22:30 PDT, Kent Tamura 		yutak: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-28 22:20:12 PDT
Created attachment 171157 [details] Patch
Kent Tamura
Comment 2 2012-10-28 22:21:36 PDT
Note that this name was proposed by ap in https://bugs.webkit.org/show_bug.cgi?id=100329#c3
WebKit Review Bot
Comment 3 2012-10-28 22:25:08 PDT
Attachment 171157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/text/PlatformLocale.h:26: #ifndef header guard has wrong style, please use: PlatformLocale_h [build/header_guard] [5] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 4 2012-10-28 22:25:53 PDT
Comment on attachment 171157 [details] Patch Attachment 171157 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14613961
Early Warning System Bot
Comment 5 2012-10-28 22:26:51 PDT
Comment on attachment 171157 [details] Patch Attachment 171157 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14626030
Kent Tamura
Comment 6 2012-10-28 22:30:08 PDT
Created attachment 171158 [details] Patch 2 Build fixes
WebKit Review Bot
Comment 7 2012-10-28 22:32:57 PDT
Attachment 171158 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/text/PlatformLocale.h:26: #ifndef header guard has wrong style, please use: PlatformLocale_h [build/header_guard] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 8 2012-10-28 22:34:24 PDT
(In reply to comment #7) > Source/WebCore/platform/text/PlatformLocale.h:26: #ifndef header guard has wrong style, please use: PlatformLocale_h [build/header_guard] [5] This is expected. I'll fix it in the next patch.
Kentaro Hara
Comment 9 2012-10-28 23:58:18 PDT
Comment on attachment 171158 [details] Patch 2 OK
Yuta Kitamura
Comment 10 2012-10-28 23:59:27 PDT
Comment on attachment 171158 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=171158&action=review > Source/WebCore/ChangeLog:9 > + PlatformLocal.cpp and PlatformLocale.h as their file names because PlatformLocal*e*.cpp
Yuta Kitamura
Comment 11 2012-10-29 00:00:30 PDT
Comment on attachment 171158 [details] Patch 2 Oops, I've overridden haraken's r+. The patch looks OK to me.
Kent Tamura
Comment 12 2012-10-29 00:01:45 PDT
Comment on attachment 171158 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=171158&action=review >> Source/WebCore/ChangeLog:9 >> + PlatformLocal.cpp and PlatformLocale.h as their file names because > > PlatformLocal*e*.cpp Will fix.
Kent Tamura
Comment 13 2012-10-29 00:02:57 PDT
Committed r132762: <http://trac.webkit.org/changeset/132762>
Note You need to log in before you can comment on or make changes to this bug.