Bug 100627 - Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
Summary: Rename Localizer.{cpp,h} to PlatformLocale.{cpp,h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 100329
  Show dependency tree / graph
 
Reported: 2012-10-28 21:48 PDT by Kent Tamura
Modified: 2012-10-29 00:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (60.58 KB, patch)
2012-10-28 22:20 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (62.59 KB, patch)
2012-10-28 22:30 PDT, Kent Tamura 		yutak: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-28 21:48:55 PDT 
without class name change.
Comment 1 Kent Tamura 2012-10-28 22:20:12 PDT 
Created attachment 171157 [details]
Patch
Comment 2 Kent Tamura 2012-10-28 22:21:36 PDT 
Note that this name was proposed by ap in https://bugs.webkit.org/show_bug.cgi?id=100329#c3
Comment 3 WebKit Review Bot 2012-10-28 22:25:08 PDT 
Attachment 171157 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/text/PlatformLocale.h:26:  #ifndef header guard has wrong style, please use: PlatformLocale_h  [build/header_guard] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2012-10-28 22:25:53 PDT 
Comment on attachment 171157 [details]
Patch

Attachment 171157 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14613961
Comment 5 Early Warning System Bot 2012-10-28 22:26:51 PDT 
Comment on attachment 171157 [details]
Patch

Attachment 171157 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14626030
Comment 6 Kent Tamura 2012-10-28 22:30:08 PDT 
Created attachment 171158 [details]
Patch 2

Build fixes
Comment 7 WebKit Review Bot 2012-10-28 22:32:57 PDT 
Attachment 171158 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/text/PlatformLocale.h:26:  #ifndef header guard has wrong style, please use: PlatformLocale_h  [build/header_guard] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Kent Tamura 2012-10-28 22:34:24 PDT 
(In reply to comment #7)
> Source/WebCore/platform/text/PlatformLocale.h:26:  #ifndef header guard has wrong style, please use: PlatformLocale_h  [build/header_guard] [5]

This is expected. I'll fix it in the next patch.
Comment 9 Kentaro Hara 2012-10-28 23:58:18 PDT 
Comment on attachment 171158 [details]
Patch 2

OK
Comment 10 Yuta Kitamura 2012-10-28 23:59:27 PDT 
Comment on attachment 171158 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=171158&action=review

> Source/WebCore/ChangeLog:9
> +        PlatformLocal.cpp and PlatformLocale.h as their file names because

PlatformLocal*e*.cpp
Comment 11 Yuta Kitamura 2012-10-29 00:00:30 PDT 
Comment on attachment 171158 [details]
Patch 2

Oops, I've overridden haraken's r+. The patch looks OK to me.
Comment 12 Kent Tamura 2012-10-29 00:01:45 PDT 
Comment on attachment 171158 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=171158&action=review

>> Source/WebCore/ChangeLog:9
>> +        PlatformLocal.cpp and PlatformLocale.h as their file names because
> 
> PlatformLocal*e*.cpp

Will fix.
Comment 13 Kent Tamura 2012-10-29 00:02:57 PDT 
Committed r132762: <http://trac.webkit.org/changeset/132762>