Bug 100625 - [Refactoring] Remove ElementShadow::insertionPointFor
Summary: [Refactoring] Remove ElementShadow::insertionPointFor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 97279
  Show dependency treegraph
 
Reported: 2012-10-28 21:32 PDT by Shinya Kawanaka
Modified: 2012-10-30 00:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.07 KB, patch)
2012-10-28 21:43 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (4.03 KB, patch)
2012-10-29 19:57 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (4.03 KB, patch)
2012-10-29 19:58 PDT, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-10-28 21:32:25 PDT
Now that it does not do something special. 
We can remove it.

This is a follow-up bug for https://bugs.webkit.org/show_bug.cgi?id=99228
Comment 1 Shinya Kawanaka 2012-10-28 21:43:19 PDT
Created attachment 171155 [details]
Patch
Comment 2 Hajime Morrita 2012-10-29 05:58:26 PDT
Comment on attachment 171155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171155&action=review

> Source/WebCore/ChangeLog:8
> +        Now that ElementShadow::insertionPointFor does not do some special things, and it's only used in

s/some/any/
Comment 3 Shinya Kawanaka 2012-10-29 19:57:06 PDT
Created attachment 171362 [details]
Patch for landing
Comment 4 Shinya Kawanaka 2012-10-29 19:58:35 PDT
Created attachment 171363 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-10-30 00:00:45 PDT
Comment on attachment 171363 [details]
Patch for landing

Clearing flags on attachment: 171363

Committed r132874: <http://trac.webkit.org/changeset/132874>
Comment 6 WebKit Review Bot 2012-10-30 00:00:49 PDT
All reviewed patches have been landed.  Closing bug.