Bug 100623 - [TexMap] Make GraphicsLayerAnimation choose a proper timing function.
Summary: [TexMap] Make GraphicsLayerAnimation choose a proper timing function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-28 20:39 PDT by Dongseong Hwang
Modified: 2012-10-29 07:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2012-10-28 20:41 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Patch (3.78 KB, patch)
2012-10-29 00:18 PDT, Dongseong Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-10-28 20:39:13 PDT 
Previously, GraphicsLayerAnimation choosed a timing function in the wrong way.
Other GraphicsLayers choose a timing function in the similar way to
GraphicsLayerCA::timingFunctionForAnimationValue(). The way consists of the
following steps.
1. Try to query the timing function of the current keyframe animation value.
2. If the timing function of #1 is null, try to query the timing function of Animation.
3. If the timing function of #2 is null, return CubicBezierTimingFunction::defaultTimingFunction().

This patch makes GraphicsLayerAnimation choose a timing function in the same way
to others.
Comment 1 Dongseong Hwang 2012-10-28 20:41:51 PDT 
Created attachment 171149 [details]
Patch
Comment 2 Noam Rosenthal 2012-10-28 21:21:06 PDT 
Comment on attachment 171149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171149&action=review

> Source/WebCore/ChangeLog:8
> +        Previously, GraphicsLayerAnimation choosed a timing function in the wrong way.

Currently, GraphicsLayerAnimation chooses a timing function in the wrong way.

> Source/WebCore/ChangeLog:17
> +        to others.

to other implementations.
Comment 3 Dongseong Hwang 2012-10-29 00:18:21 PDT 
Created attachment 171166 [details]
Patch
Comment 4 Dongseong Hwang 2012-10-29 00:19:03 PDT 
(In reply to comment #2)
Thank you for your review :)

> (From update of attachment 171149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171149&action=review
> 
> Currently, GraphicsLayerAnimation chooses a timing function in the wrong way.

Done.

> 
> to other implementations.

Done.
Comment 5 WebKit Review Bot 2012-10-29 07:27:05 PDT 
Comment on attachment 171166 [details]
Patch

Clearing flags on attachment: 171166

Committed r132798: <http://trac.webkit.org/changeset/132798>
Comment 6 WebKit Review Bot 2012-10-29 07:27:08 PDT 
All reviewed patches have been landed.  Closing bug.