Bug 100619 - [touchadjustment] touch-links-two-finger-tap test pass incorrectly
Summary: [touchadjustment] touch-links-two-finger-tap test pass incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Terry Anderson
URL:
Keywords:
Depends on: 96810
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-28 16:18 PDT by Terry Anderson
Modified: 2012-10-31 15:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.11 KB, patch)
2012-10-29 13:38 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2012-10-31 10:13 PDT, Terry Anderson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Anderson 2012-10-28 16:18:05 PDT 
Once the changes in https://bugs.webkit.org/show_bug.cgi?id=96810 land, I will make similar fixes to the touch positions in touchadjustment/touch-links-two-finger-tap.html.
Comment 1 Terry Anderson 2012-10-29 13:38:01 PDT 
Created attachment 171301 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-30 02:05:25 PDT 
Comment on attachment 171301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171301&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:1211
>      case WebInputEvent::GestureTwoFingerTap:
>          event.x = point.x;
>          event.y = point.y;
> +        if (arguments.size() >= 4) {
> +            event.data.twoFingerTap.firstFingerWidth = static_cast<float>(arguments[2].toDouble());
> +            event.data.twoFingerTap.firstFingerHeight = static_cast<float>(arguments[3].toDouble());
> +        }
>          break;

IS this code really chromium specific?
Comment 3 Terry Anderson 2012-10-31 10:13:40 PDT 
Created attachment 171679 [details]
Patch
Comment 4 Terry Anderson 2012-10-31 10:15:39 PDT 
(In reply to comment #2)
> (From update of attachment 171301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171301&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:1211
> >      case WebInputEvent::GestureTwoFingerTap:
> >          event.x = point.x;
> >          event.y = point.y;
> > +        if (arguments.size() >= 4) {
> > +            event.data.twoFingerTap.firstFingerWidth = static_cast<float>(arguments[2].toDouble());
> > +            event.data.twoFingerTap.firstFingerHeight = static_cast<float>(arguments[3].toDouble());
> > +        }
> >          break;
> 
> IS this code really chromium specific?

Yes, it is chromium specific since it refers to the |twoFingerTap| struct inside of chromium's WebInputEvent.h
Comment 5 WebKit Review Bot 2012-10-31 15:11:18 PDT 
Comment on attachment 171679 [details]
Patch

Clearing flags on attachment: 171679

Committed r133082: <http://trac.webkit.org/changeset/133082>
Comment 6 WebKit Review Bot 2012-10-31 15:11:22 PDT 
All reviewed patches have been landed.  Closing bug.