Bug 100619 – [touchadjustment] touch-links-two-finger-tap test pass incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Terry Anderson]

Once the changes in https://bugs.webkit.org/show_bug.cgi?id=96810 land, I will make similar fixes to the touch positions in touchadjustment/touch-links-two-finger-tap.html.

[Terry Anderson]

Created attachment 171301 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 171301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171301&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:1211
>      case WebInputEvent::GestureTwoFingerTap:
>          event.x = point.x;
>          event.y = point.y;
> +        if (arguments.size() >= 4) {
> +            event.data.twoFingerTap.firstFingerWidth = static_cast<float>(arguments[2].toDouble());
> +            event.data.twoFingerTap.firstFingerHeight = static_cast<float>(arguments[3].toDouble());
> +        }
>          break;

IS this code really chromium specific?

[Terry Anderson]

Created attachment 171679 [details]
Patch

[Terry Anderson]

(In reply to comment #2)
> (From update of attachment 171301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171301&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:1211
> >      case WebInputEvent::GestureTwoFingerTap:
> >          event.x = point.x;
> >          event.y = point.y;
> > +        if (arguments.size() >= 4) {
> > +            event.data.twoFingerTap.firstFingerWidth = static_cast<float>(arguments[2].toDouble());
> > +            event.data.twoFingerTap.firstFingerHeight = static_cast<float>(arguments[3].toDouble());
> > +        }
> >          break;
> 
> IS this code really chromium specific?

Yes, it is chromium specific since it refers to the |twoFingerTap| struct inside of chromium's WebInputEvent.h

[WebKit Review Bot]

Comment on attachment 171679 [details]
Patch

Clearing flags on attachment: 171679

Committed r133082: <http://trac.webkit.org/changeset/133082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.