Bug 100614 - [BlackBerry] Simplify AuthenticationChallengeManager::instance
Summary: [BlackBerry] Simplify AuthenticationChallengeManager::instance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-28 13:39 PDT by Rob Buis
Modified: 2012-10-29 14:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2012-10-28 13:44 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2012-10-29 13:30 PDT, Rob Buis 		yong.li.webkit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-10-28 13:39:39 PDT 
SSIA
Comment 1 Rob Buis 2012-10-28 13:44:47 PDT 
Created attachment 171141 [details]
Patch
Comment 2 Jacky Jiang 2012-10-29 08:04:17 PDT 
Comment on attachment 171141 [details]
Patch

It is the same as this: static AuthenticationChallengeManager* s_manager = new AuthenticationChallengeManager();  return s_manager;  right?  What about  DEFINE_STATIC_LOCAL?
Comment 3 Rob Buis 2012-10-29 13:30:16 PDT 
Created attachment 171299 [details]
Patch
Comment 4 Yong Li 2012-10-29 14:35:59 PDT 
Comment on attachment 171299 [details]
Patch

LGTM. might want to add Lyon as internal reviewer?
Comment 5 Rob Buis 2012-10-29 14:54:47 PDT 
Committed r132851: <http://trac.webkit.org/changeset/132851>