String::split(UChar separator, Vector<String>& result) creates a single character string from the first argument and then calls the String::split(const String&, bool, Vector<String>&). Instead it could call the (UChar, bool, Vector<String>&) version of String::split.
Created attachment 171061 [details] Patch
Comment on attachment 171061 [details] Patch Rejecting attachment 171061 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: erge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0002 Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14610261
Comment on attachment 171061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171061&action=review > Source/WTF/wtf/text/WTFString.cpp:691 > void String::split(UChar separator, Vector<String>& result) const > { > - split(String(&separator, 1), false, result); > + split(separator, false, result); > } This could also be inlined in the header.
Created attachment 171279 [details] Patch with inlined versions of 2 arg split()
Comment on attachment 171279 [details] Patch with inlined versions of 2 arg split() Clearing flags on attachment: 171279 Committed r132828: <http://trac.webkit.org/changeset/132828>
All reviewed patches have been landed. Closing bug.