RESOLVED FIXED 100564
Remove internals shouldDisplayTrackKind methods; these are also on internals.settings 
https://bugs.webkit.org/show_bug.cgi?id=100564
Summary Remove internals shouldDisplayTrackKind methods; these are also on internals....
Tony Chang
Reported 2012-10-26 14:41:31 PDT
Remove internals shouldDisplayTrackKind methods; these are also on internals.settings
Attachments
Patch (11.99 KB, patch)
2012-10-26 15:24 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-10-26 15:24:46 PDT
Created attachment 171027 [details] Patch
WebKit Review Bot
Comment 2 2012-10-27 08:14:00 PDT
Comment on attachment 171027 [details] Patch Rejecting attachment 171027 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14610457
WebKit Review Bot
Comment 3 2012-10-27 08:14:01 PDT
Comment on attachment 171027 [details] Patch Rejecting attachment 171027 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14617436
WebKit Review Bot
Comment 4 2012-10-27 08:14:04 PDT
Comment on attachment 171027 [details] Patch Clearing flags on attachment: 171027 Committed r132726: <http://trac.webkit.org/changeset/132726>
WebKit Review Bot
Comment 5 2012-10-27 08:14:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.