Bug 100564 - Remove internals shouldDisplayTrackKind methods; these are also on internals.settings
Summary: Remove internals shouldDisplayTrackKind methods; these are also on internals....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 100393
  Show dependency treegraph
 
Reported: 2012-10-26 14:41 PDT by Tony Chang
Modified: 2012-10-27 08:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.99 KB, patch)
2012-10-26 15:24 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-10-26 14:41:31 PDT
Remove internals shouldDisplayTrackKind methods; these are also on internals.settings
Comment 1 Tony Chang 2012-10-26 15:24:46 PDT
Created attachment 171027 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-27 08:14:00 PDT
Comment on attachment 171027 [details]
Patch

Rejecting attachment 171027 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14610457
Comment 3 WebKit Review Bot 2012-10-27 08:14:01 PDT
Comment on attachment 171027 [details]
Patch

Rejecting attachment 171027 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14617436
Comment 4 WebKit Review Bot 2012-10-27 08:14:04 PDT
Comment on attachment 171027 [details]
Patch

Clearing flags on attachment: 171027

Committed r132726: <http://trac.webkit.org/changeset/132726>
Comment 5 WebKit Review Bot 2012-10-27 08:14:07 PDT
All reviewed patches have been landed.  Closing bug.