Bug 100559 - Add ENABLE_USERSELECT_ALL feature flag
Summary: Add ENABLE_USERSELECT_ALL feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-26 14:12 PDT by Enrica Casucci
Modified: 2012-10-29 18:38 PDT (History)
0 users

See Also:

Attachments
Patch (23.29 KB, patch)
2012-10-26 14:37 PDT, Enrica Casucci 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2012-10-26 14:12:36 PDT 
Add ENABLE_USERSELECT_ALL feature flag.
Comment 1 Enrica Casucci 2012-10-26 14:37:49 PDT 
Created attachment 171015 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-26 18:14:14 PDT 
Comment on attachment 171015 [details]
Patch

Looks reasonable.
Comment 3 Enrica Casucci 2012-10-29 10:11:13 PDT 
Committed revision 132812.
Comment 4 Kent Tamura 2012-10-29 17:54:58 PDT 
Please update http://trac.webkit.org/wiki/FeatureFlags.
Also, please post an announcement of this feature to webkit-dev.  http://www.webkit.org/coding/adding-features.html
Comment 5 Enrica Casucci 2012-10-29 18:34:45 PDT 
(In reply to comment #4)
> Please update http://trac.webkit.org/wiki/FeatureFlags.
> Also, please post an announcement of this feature to webkit-dev.  http://www.webkit.org/coding/adding-features.html

I'm pretty sure it was announced a while ago. I'll try to find the email.
Comment 6 Enrica Casucci 2012-10-29 18:38:05 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Please update http://trac.webkit.org/wiki/FeatureFlags.
> > Also, please post an announcement of this feature to webkit-dev.  http://www.webkit.org/coding/adding-features.html
> 
> I'm pretty sure it was announced a while ago. I'll try to find the email.

There is thread on webkit-dev started on June 23 by Alice Cheng with the subject "new -webkit-user-select value: atomic" where this is discussed. As you'll see in the thread the value was then changed from atomic to all.