Bug 100558 – [CSS Shaders] Add the ValidatedCustomFilterOperation class

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

Add the ValidatedCustomFilterOperation to the project files.

Look in the parent bug for more details: https://bugs.webkit.org/show_bug.cgi?id=100533

[Alexandru Chiculita]

Created attachment 171017 [details]
Patch V1

[Build Bot]

Comment on attachment 171017 [details]
Patch V1

Attachment 171017 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14608218

[Alexandru Chiculita]

Created attachment 171034 [details]
Patch V2

[Dean Jackson]

Comment on attachment 171034 [details]
Patch V2

View in context: https://bugs.webkit.org/attachment.cgi?id=171034&action=review

> Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.h:60
> +    virtual bool operator==(const FilterOperation& o) const
> +    {
> +        if (!isSameType(o))
> +            return false;
> +
> +        return true;
> +    }

While this is unimportant, I think we should return false while this remains unimplemented. I'm happy for you to ignore me here.

[Alexandru Chiculita]

Comment on attachment 171034 [details]
Patch V2

Thanks Dean! I will implement that function in the following patch anyway, so I'm just adding cq+ for this patch.

[WebKit Review Bot]

Comment on attachment 171034 [details]
Patch V2

Rejecting attachment 171034 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ium.cpp
patching file Source/WebCore/platform/graphics/filters/FilterOperation.h
patching file Source/WebCore/platform/graphics/filters/FilterOperations.cpp
patching file Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.cpp
patching file Source/WebCore/platform/graphics/filters/ValidatedCustomFilterOperation.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Dean Jacks..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14620878

[Alexandru Chiculita]

Landed manually in http://trac.webkit.org/changeset/132927 .

[Vincent Scheib]

Error:
..\platform\graphics\filters\ValidatedCustomFilterOperation.cpp(51):error C2027: use of undefined type 'WebCore::FractionalLayoutSize'
         C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebCore\rendering\LayoutTypes.h(44) : see declaration of 'WebCore::FractionalLayoutSize'

build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/32028
and other windows builders.

[Vincent Scheib]

Rolled out in:
http://trac.webkit.org/changeset/132947

[Alexandru Chiculita]

Created attachment 171545 [details]
Patch V3

Adding the FractionalLayoutSize.h in the ValidatedCustomFilterOperation

[Alexandru Chiculita]

(In reply to comment #10)
> Created an attachment (id=171545) [details]
> Patch V3
> 
> Adding the FractionalLayoutSize.h in the ValidatedCustomFilterOperation

Landed again in http://trac.webkit.org/changeset/132960 .