Bug 100553 – [chromium] Allow implicit conversion between gfx::Vector2d and WebSize

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Allow implicit conversion between gfx::Vector2d and WebSize

[Dana Jansens]

Created attachment 170986 [details]
Patch

[Dana Jansens]

This depends on https://codereview.chromium.org/11269022/ for gfx::Vector2d to exist.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 170986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review

Be sure to reverse-roll before landing this

> Source/Platform/ChangeLog:9
> +        IntSize class is used equivalently inside WebCore. This let's us convert

It's "lets", not "let's".

(insert favorite apostrophe meme here)

[WebKit Review Bot]

Comment on attachment 170986 [details]
Patch

Attachment 170986 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14605235

[Dana Jansens]

Created attachment 170992 [details]
Patch

[Dana Jansens]

(In reply to comment #4)
> (From update of attachment 170986 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170986&action=review
> 
> Be sure to reverse-roll before landing this

Yup! Thanks :)

[WebKit Review Bot]

Comment on attachment 170992 [details]
Patch

Rejecting attachment 170992 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
'&' token
Source/Platform/chromium/public/WebSize.h:101: error: 'WebKit::WebSize& WebKit::WebSize::operator=(...)' must not have variable number of arguments
Source/Platform/chromium/public/WebSize.h:101: error: expected ';' before '&' token
Source/Platform/chromium/public/WebSize.h:108: error: expected ';' before 'operator'
Source/Platform/chromium/public/WebSize.h:113: error: expected type-specifier
make: *** [out/Release/obj.target/cc/Source/WebKit/chromium/cc/layer_tree_host_impl.o] Error 1

Full output: http://queues.webkit.org/results/14686554

[WebKit Review Bot]

Comment on attachment 170992 [details]
Patch

Clearing flags on attachment: 170992

Committed r133198: <http://trac.webkit.org/changeset/133198>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.