Bug 100548 – [CSS Shaders] Extract the CustomFilterParameterList to its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Alexandru Chiculita]

CustomFilterParameterList is defined as a typedef in the header of CustomFilterOperation. We will reuse the CustomFilterParameterList in different other places, so extract that to its own file.

[Alexandru Chiculita]

Created attachment 170993 [details]
Patch V1

[Early Warning System Bot]

Comment on attachment 170993 [details]
Patch V1

Attachment 170993 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14610169

[Alexandru Chiculita]

Created attachment 171025 [details]
Patch V2

[WebKit Review Bot]

Attachment 171025 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:43:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:44:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 171025 [details]
Patch V2

Attachment 171025 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14593824

[Early Warning System Bot]

Comment on attachment 171025 [details]
Patch V2

Attachment 171025 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14617145

[Alexandru Chiculita]

Created attachment 171026 [details]
Patch V3

[Max Vujovic]

Comment on attachment 171026 [details]
Patch V3

Looks good, Alex.

View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterParameterList.cpp:49
> +bool CustomFilterParameterList::operator==(const CustomFilterParameterList& other) const

Nice. An operator== looks much better than customFilterParametersEqual(...).

> Source/WebCore/platform/graphics/filters/CustomFilterParameterList.h:45
> +    explicit CustomFilterParameterList(size_t);

Nice use of explicit.

[EFL EWS Bot]

Comment on attachment 171026 [details]
Patch V3

Attachment 171026 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14608279

[Dean Jackson]

Comment on attachment 171026 [details]
Patch V3

I like this patch. Not sure why EFL couldn't find the new file, but assuming that works itself out, I'm happy.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 171026 [details]
Patch V3

View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review

> Source/WebCore/CMakeLists.txt:1914
> +    platform/graphics/filters/CustomFilterParameter.cpp

The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp.

[Dean Jackson]

(In reply to comment #11)
> (From update of attachment 171026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review
> 
> > Source/WebCore/CMakeLists.txt:1914
> > +    platform/graphics/filters/CustomFilterParameter.cpp
> 
> The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp.

Ah, thanks! No need to r- then because it is an easy fix.

[Alexandru Chiculita]

(In reply to comment #12)
> (In reply to comment #11)
> > (From update of attachment 171026 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=171026&action=review
> > 
> > > Source/WebCore/CMakeLists.txt:1914
> > > +    platform/graphics/filters/CustomFilterParameter.cpp
> > 
> > The file is called CustomFilterParameterList.cpp, not CustomFilterParameter.cpp.
> 
> Ah, thanks! No need to r- then because it is an easy fix.

Thanks, Dean! Sorry about the naming, it's the evil copy-paste :)

[Alexandru Chiculita]

Created attachment 171258 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 171258 [details]
Patch for landing

Clearing flags on attachment: 171258

Committed r132808: <http://trac.webkit.org/changeset/132808>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.