Bug 100540 – [EFL][WK2][AC] Build fix after r132647

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Yael]

Patch is coming

[Yael]

Created attachment 170957 [details]
Patch

[kalyan]

+        evas_gl_surface_destroy(impl->evasGl(), impl->evasGlSurface());

Should we actually move the surface destruction to resetEvasGlSurface(in view impl).EwkViewImpl::exitAcceleratedCompositingMode could also call this internally.

[Yael]

(In reply to comment #2)
> +        evas_gl_surface_destroy(impl->evasGl(), impl->evasGlSurface());
> 
> Should we actually move the surface destruction to resetEvasGlSurface(in view impl).EwkViewImpl::exitAcceleratedCompositingMode could also call this internally.

This is just a build fix. If we want to change more than that, I would prefer to do that in a separate bug.

[Chris Dumez]

Comment on attachment 170957 [details]
Patch

LGTM.

[Chris Dumez]

(In reply to comment #2)
> +        evas_gl_surface_destroy(impl->evasGl(), impl->evasGlSurface());
> 
> Should we actually move the surface destruction to resetEvasGlSurface(in view impl).EwkViewImpl::exitAcceleratedCompositingMode could also call this internally.

Yes, I agree with this too (in this patch or another).

[Yael]

(In reply to comment #5)
> (In reply to comment #2)
> > +        evas_gl_surface_destroy(impl->evasGl(), impl->evasGlSurface());
> > 
> > Should we actually move the surface destruction to resetEvasGlSurface(in view impl).EwkViewImpl::exitAcceleratedCompositingMode could also call this internally.
> 
> Yes, I agree with this too (in this patch or another).

I actually prefer to get rid of enterAcceleratedCompositingMode/exitAcceleratedCompositingMode .
No other port implements it, so we shouldn't either.

[WebKit Review Bot]

Comment on attachment 170957 [details]
Patch

Clearing flags on attachment: 170957

Committed r132706: <http://trac.webkit.org/changeset/132706>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.