RESOLVED FIXED 10054
ICU should be abstracted out from WebCore 
https://bugs.webkit.org/show_bug.cgi?id=10054
Summary ICU should be abstracted out from WebCore
Antti Koivisto
Reported 2006-07-21 15:47:25 PDT
ICU library can not be used on all platforms. For example it is far too big to use in mobile devices. There should be a unicode abstraction layer (like JSC already has) which can map to ICU or some platform functionality. Creating a bug for tracking this.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2006-07-21 20:22:36 PDT
George Staikos has begun doing just this on the Unity project (branch?) and I am looking into working it back into the trunk.
Alexey Proskuryakov
Comment 2 2006-12-09 02:20:29 PST
Done by Lars Knoll and Hyatt in r18098.
David Kilzer (:ddkilzer)
Comment 3 2006-12-09 03:56:46 PST
(In reply to comment #2) > Done by Lars Knoll and Hyatt in r18098. Follow-up build fixes in r18099-r18105.
Alexey Proskuryakov
Comment 4 2006-12-09 04:03:35 PST
> > Done by Lars Knoll and Hyatt in r18098. > Follow-up build fixes in r18099-r18105. This change has caused a failure in tables/mozilla/bugs/bug33855.html
mitz
Comment 5 2006-12-10 00:28:07 PST
(In reply to comment #4) > > > Done by Lars Knoll and Hyatt in r18098. > > Follow-up build fixes in r18099-r18105. > > This change has caused a failure in tables/mozilla/bugs/bug33855.html > Specifically this change in StringImpl.cpp: - return c <= 0x7F ? isspace(c) : (u_charDirection(c) == U_WHITE_SPACE_NEUTRAL); + return c <= 0x7F ? isspace(c) : WTF::Unicode::isSpace(c);
Dave Hyatt
Comment 6 2006-12-10 00:35:41 PST
Heh I caught that line in review and asked if it was still equivalent. I guess it isn't.
Dave Hyatt
Comment 7 2006-12-10 00:49:11 PST
Let's get a regression bug filed.
mitz
Comment 8 2006-12-10 01:54:48 PST
(In reply to comment #7) > Let's get a regression bug filed. > Bug 11795.
Note You need to log in before you can comment on or make changes to this bug.