IndexedDB: Use sequence<> instead of DOMString[] in IDL
Created attachment 170958 [details] Patch
alecflett@ - please take a look
Comment on attachment 170958 [details] Patch What benefit does this change have? It looks like all you've done is introduce an extra copy operation.
Sorry, needs context - The DOMString[] support in the binding code is a hack that treats it as DOMStringList. This predates sequence<T> support. I'd like to remove the hack, and removing uses of DOMString[] is part of it. This can wait until the other bugs land and the copy is unnecessary, and/or I can bundle it with more DOMString[] removal/cleanup. Either way, I'll park this for now as it's not useful on its own.
That sounds worth doing, but it's probably worth waiting until we can avoid introducing extra copies.
Created attachment 173711 [details] Patch
Updated the patch now that the copy is no longer needed, but it's still not urgent to land this, and can be done in conjunction with other DOMString[] cleanup.
I'd love to see this land sooner rather than later, since it's a working patch right now...LGTM
Comment on attachment 173711 [details] Patch Well, in that case - r? cq?
Comment on attachment 173711 [details] Patch ok
Comment on attachment 173711 [details] Patch Clearing flags on attachment: 173711 Committed r134342: <http://trac.webkit.org/changeset/134342>
All reviewed patches have been landed. Closing bug.