WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100532
[CSS Shaders] Software and composited filters should have a common path
https://bugs.webkit.org/show_bug.cgi?id=100532
Summary
[CSS Shaders] Software and composited filters should have a common path
Alexandru Chiculita
Reported
2012-10-26 09:15:41 PDT
Software and composited filters path need a common method that can analyze the filters and optimize them.
Attachments
Patch V1
(5.59 KB, patch)
2012-10-26 09:37 PDT
,
Alexandru Chiculita
no flags
Details
Formatted Diff
Diff
Patch V2
(5.61 KB, patch)
2012-10-26 14:50 PDT
,
Alexandru Chiculita
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexandru Chiculita
Comment 1
2012-10-26 09:37:37 PDT
Created
attachment 170945
[details]
Patch V1
Max Vujovic
Comment 2
2012-10-26 14:42:05 PDT
Comment on
attachment 170945
[details]
Patch V1 Looks good, Alex. View in context:
https://bugs.webkit.org/attachment.cgi?id=170945&action=review
> Source/WebCore/rendering/RenderLayer.cpp:5097 > + // Note that RenderLayerFilterInfo will handle the loading and repainting of the layer automatically.
Maybe reword this comment like "...will handle the loading of the shaders and repainting of the layer." It sounds like the layer is loading right now.
Alexandru Chiculita
Comment 3
2012-10-26 14:50:02 PDT
Created
attachment 171018
[details]
Patch V2
WebKit Review Bot
Comment 4
2012-10-30 03:33:30 PDT
Comment on
attachment 171018
[details]
Patch V2 Clearing flags on attachment: 171018 Committed
r132889
: <
http://trac.webkit.org/changeset/132889
>
WebKit Review Bot
Comment 5
2012-10-30 03:33:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug