Bug 100532 - [CSS Shaders] Software and composited filters should have a common path
Summary: [CSS Shaders] Software and composited filters should have a common path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks: 100533
  Show dependency tree / graph
 
Reported: 2012-10-26 09:15 PDT by Alexandru Chiculita
Modified: 2012-10-30 03:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch V1 (5.59 KB, patch)
2012-10-26 09:37 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Patch V2 (5.61 KB, patch)
2012-10-26 14:50 PDT, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2012-10-26 09:15:41 PDT 
Software and composited filters path need a common method that can analyze the filters and optimize them.
Comment 1 Alexandru Chiculita 2012-10-26 09:37:37 PDT 
Created attachment 170945 [details]
Patch V1
Comment 2 Max Vujovic 2012-10-26 14:42:05 PDT 
Comment on attachment 170945 [details]
Patch V1

Looks good, Alex.

View in context: https://bugs.webkit.org/attachment.cgi?id=170945&action=review

> Source/WebCore/rendering/RenderLayer.cpp:5097
> +            // Note that RenderLayerFilterInfo will handle the loading and repainting of the layer automatically.

Maybe reword this comment like "...will handle the loading of the shaders and repainting of the layer." It sounds like the layer is loading right now.
Comment 3 Alexandru Chiculita 2012-10-26 14:50:02 PDT 
Created attachment 171018 [details]
Patch V2
Comment 4 WebKit Review Bot 2012-10-30 03:33:30 PDT 
Comment on attachment 171018 [details]
Patch V2

Clearing flags on attachment: 171018

Committed r132889: <http://trac.webkit.org/changeset/132889>
Comment 5 WebKit Review Bot 2012-10-30 03:33:33 PDT 
All reviewed patches have been landed.  Closing bug.