Bug 100530 - Web Inspector: Timeline: make cpu-monitoring feature available only on capable browsers
Summary: Web Inspector: Timeline: make cpu-monitoring feature available only on capabl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-26 08:52 PDT by eustas.bug
Modified: 2012-10-29 05:40 PDT (History)
14 users (show)

See Also:

Attachments
Patch (9.00 KB, patch)
2012-10-26 09:07 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Patch (8.87 KB, patch)
2012-10-29 01:33 PDT, eustas.bug 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-10-26 08:52:05 PDT 
Motivation: cpu-monitoring feature looks like a glitch, when it is not supported by browser.
Comment 1 eustas.bug 2012-10-26 09:07:51 PDT 
Created attachment 170942 [details]
Patch
Comment 2 Yury Semikhatsky 2012-10-29 00:04:12 PDT 
Comment on attachment 170942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review

> Source/WebCore/inspector/InspectorClient.h:60
> +    virtual bool supportsMainThreadMonitoring() { return false; }

Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client.
Comment 3 eustas.bug 2012-10-29 01:28:45 PDT 
Comment on attachment 170942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170942&action=review

>> Source/WebCore/inspector/InspectorClient.h:60
>> +    virtual bool supportsMainThreadMonitoring() { return false; }
> 
> Please rename it to canMainThreadMonitoring for consistency with other similar methods on the client.

done
Comment 4 eustas.bug 2012-10-29 01:33:18 PDT 
Created attachment 171176 [details]
Patch
Comment 5 WebKit Review Bot 2012-10-29 05:40:23 PDT 
Comment on attachment 171176 [details]
Patch

Clearing flags on attachment: 171176

Committed r132788: <http://trac.webkit.org/changeset/132788>
Comment 6 WebKit Review Bot 2012-10-29 05:40:26 PDT 
All reviewed patches have been landed.  Closing bug.