RESOLVED FIXED 100521
Web Inspector: Error messages lines in console are 1px taller than regular messages 
https://bugs.webkit.org/show_bug.cgi?id=100521
Summary Web Inspector: Error messages lines in console are 1px taller than regular me...
dubroy
Reported 2012-10-26 07:41:16 PDT
In the Console, error message (in red text) have 1 extra pixel of empty space below them, as compared to regular message.
Attachments
Before. (63.40 KB, image/png)
2012-10-26 11:30 PDT, Mike West 		no flags
Details
After. (63.55 KB, image/png)
2012-10-26 11:33 PDT, Mike West 		no flags
Details
Patch (1.90 KB, patch)
2012-10-26 11:42 PDT, Mike West 		pfeldman: review+
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2012-10-29 01:25 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
After after. :) (114.43 KB, image/png)
2012-10-29 01:26 PDT, Mike West 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dubroy
Comment 1 2012-10-26 07:41:36 PDT
mkwst please to be fixing :-)
Mike West
Comment 2 2012-10-26 11:30:54 PDT
Created attachment 170966 [details] Before.
Mike West
Comment 3 2012-10-26 11:33:24 PDT
Created attachment 170968 [details] After.
Mike West
Comment 4 2012-10-26 11:42:01 PDT
Created attachment 170974 [details] Patch
Alexander Pavlov (apavlov)
Comment 5 2012-10-29 01:08:36 PDT
Comment on attachment 170974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170974&action=review > Source/WebCore/ChangeLog:9 > + messages and traces will be nicely centered in their line. This way, the error message and console.trace() log entries look 1px taller than the other ones, which seem to have retained their height... Is this intentional?
Mike West
Comment 6 2012-10-29 01:12:54 PDT
(In reply to comment #5) > (From update of attachment 170974 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170974&action=review > > > Source/WebCore/ChangeLog:9 > > + messages and traces will be nicely centered in their line. > > This way, the error message and console.trace() log entries look 1px taller than the other ones, which seem to have retained their height... Is this intentional? Hrm. I think you're right. Good eyes. :) I'll fiddle some more.
Mike West
Comment 7 2012-10-29 01:25:49 PDT
Created attachment 171174 [details] Patch
Mike West
Comment 8 2012-10-29 01:26:45 PDT
Created attachment 171175 [details] After after. :)
Mike West
Comment 9 2012-10-29 01:28:08 PDT
Comment on attachment 171174 [details] Patch Danke. :) CQing.
WebKit Review Bot
Comment 10 2012-10-29 01:50:08 PDT
Comment on attachment 171174 [details] Patch Clearing flags on attachment: 171174 Committed r132773: <http://trac.webkit.org/changeset/132773>
WebKit Review Bot
Comment 11 2012-10-29 01:50:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.