Bug 100498 – REGRESSION(r132589): Breaks font-face layout tests (Requested by pfeldman on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/132589 broke the build:
Breaks font-face layout tests (Requested by pfeldman on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 170884 [details]
ROLLOUT of r132589

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Pavel Feldman]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2Ffont-face-implicit-local-font.html%2Cfast%2Fcss%2Ffont-face-multiple-faces.html%2Csvg%2Fcustom%2Ffont-face-simple.svg%2Cfast%2Frepaint%2Fselection-after-remove.html

[WebKit Review Bot]

Comment on attachment 170884 [details]
ROLLOUT of r132589

Clearing flags on attachment: 170884

Committed r132620: <http://trac.webkit.org/changeset/132620>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kenichi Ishibashi]

This isn't a regression. These tests depend on how FontCache implicitly replaces font family. That's wrong. We need to  update these tests.

[Pavel Feldman]

(In reply to comment #5)
> This isn't a regression. These tests depend on how FontCache implicitly replaces font family. That's wrong. We need to  update these tests.

I don't think so. The tests explicitly require different font families. I.e. either these tests are entirely wrong (should not exist) or you are introducing unexpected behavior change.