Bug 100497 – Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

Otherwise we report a pointer to the base class which is not an address of an object allocated on the heap.

[Yury Semikhatsky]

Created attachment 170883 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 170883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170883&action=review

> Source/WebCore/ChangeLog:8
> +        Added memory reporting method to chromium implementation of ResourceRequest.

could you please explain the reason of this change.

[Early Warning System Bot]

Comment on attachment 170883 [details]
Patch

Attachment 170883 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14562981

[Early Warning System Bot]

Comment on attachment 170883 [details]
Patch

Attachment 170883 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14564996

[Yury Semikhatsky]

Created attachment 170891 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #2)
> (From update of attachment 170883 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170883&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Added memory reporting method to chromium implementation of ResourceRequest.
> 
> could you please explain the reason of this change.

Done.

[Ilya Tikhonovsky]

Comment on attachment 170891 [details]
Patch

lgtm

[Alexander Pavlov (apavlov)]

Comment on attachment 170891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170891&action=review

A few textual nits to fix before landing.

> Source/WebCore/ChangeLog:8
> +        Added memory reporting method to chromium implementation of ResourceRequest.

chromium -> Chromium?

> Source/WebCore/ChangeLog:15
> +        and shouldn't be used directly(ResourceRequest should be used instead).

add a space before '('

[Yury Semikhatsky]

(In reply to comment #8)
> (From update of attachment 170891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170891&action=review
> 
> A few textual nits to fix before landing.
> 
> > Source/WebCore/ChangeLog:8
> > +        Added memory reporting method to chromium implementation of ResourceRequest.
> 
> chromium -> Chromium?
> 
Done.

> > Source/WebCore/ChangeLog:15
> > +        and shouldn't be used directly(ResourceRequest should be used instead).
> 
> add a space before '('
Done.

[Yury Semikhatsky]

Committed r132644: <http://trac.webkit.org/changeset/132644>

[Vincent Scheib]

Reverted r132644 for reason:

Causes webkit_unit_tests MemoryInstrumentationTest.ImageObserver to fail.

Committed r132675: <http://trac.webkit.org/changeset/132675>

[Yury Semikhatsky]

(In reply to comment #11)
> Reverted r132644 for reason:
> 
> Causes webkit_unit_tests MemoryInstrumentationTest.ImageObserver to fail.
> 
> Committed r132675: <http://trac.webkit.org/changeset/132675>

Is there a link to the failing bot output?

[Yury Semikhatsky]

Created attachment 171790 [details]
Patch

[WebKit Review Bot]

Comment on attachment 171790 [details]
Patch

Clearing flags on attachment: 171790

Committed r133141: <http://trac.webkit.org/changeset/133141>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.