Bug 100497 - Memory instrumentation: report memory occupied by ResourceRequest instead of its base ResourceRequestBase
Summary: Memory instrumentation: report memory occupied by ResourceRequest instead of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-26 04:14 PDT by Yury Semikhatsky
Modified: 2012-11-01 02:28 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2012-10-26 04:16 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (5.01 KB, patch)
2012-10-26 04:42 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (9.59 KB, patch)
2012-11-01 01:05 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-10-26 04:14:50 PDT 
Otherwise we report a pointer to the base class which is not an address of an object allocated on the heap.
Comment 1 Yury Semikhatsky 2012-10-26 04:16:13 PDT 
Created attachment 170883 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-10-26 04:18:45 PDT 
Comment on attachment 170883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170883&action=review

> Source/WebCore/ChangeLog:8
> +        Added memory reporting method to chromium implementation of ResourceRequest.

could you please explain the reason of this change.
Comment 3 Early Warning System Bot 2012-10-26 04:28:53 PDT 
Comment on attachment 170883 [details]
Patch

Attachment 170883 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14562981
Comment 4 Early Warning System Bot 2012-10-26 04:31:12 PDT 
Comment on attachment 170883 [details]
Patch

Attachment 170883 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14564996
Comment 5 Yury Semikhatsky 2012-10-26 04:42:45 PDT 
Created attachment 170891 [details]
Patch
Comment 6 Yury Semikhatsky 2012-10-26 04:43:04 PDT 
(In reply to comment #2)
> (From update of attachment 170883 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170883&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Added memory reporting method to chromium implementation of ResourceRequest.
> 
> could you please explain the reason of this change.

Done.
Comment 7 Ilya Tikhonovsky 2012-10-26 04:43:51 PDT 
Comment on attachment 170891 [details]
Patch

lgtm
Comment 8 Alexander Pavlov (apavlov) 2012-10-26 04:53:22 PDT 
Comment on attachment 170891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170891&action=review

A few textual nits to fix before landing.

> Source/WebCore/ChangeLog:8
> +        Added memory reporting method to chromium implementation of ResourceRequest.

chromium -> Chromium?

> Source/WebCore/ChangeLog:15
> +        and shouldn't be used directly(ResourceRequest should be used instead).

add a space before '('
Comment 9 Yury Semikhatsky 2012-10-26 06:18:26 PDT 
(In reply to comment #8)
> (From update of attachment 170891 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170891&action=review
> 
> A few textual nits to fix before landing.
> 
> > Source/WebCore/ChangeLog:8
> > +        Added memory reporting method to chromium implementation of ResourceRequest.
> 
> chromium -> Chromium?
> 
Done.

> > Source/WebCore/ChangeLog:15
> > +        and shouldn't be used directly(ResourceRequest should be used instead).
> 
> add a space before '('
Done.
Comment 10 Yury Semikhatsky 2012-10-26 06:20:57 PDT 
Committed r132644: <http://trac.webkit.org/changeset/132644>
Comment 11 Vincent Scheib 2012-10-26 10:49:41 PDT 
Reverted r132644 for reason:

Causes webkit_unit_tests MemoryInstrumentationTest.ImageObserver to fail.

Committed r132675: <http://trac.webkit.org/changeset/132675>
Comment 12 Yury Semikhatsky 2012-10-31 02:29:04 PDT 
(In reply to comment #11)
> Reverted r132644 for reason:
> 
> Causes webkit_unit_tests MemoryInstrumentationTest.ImageObserver to fail.
> 
> Committed r132675: <http://trac.webkit.org/changeset/132675>

Is there a link to the failing bot output?
Comment 13 Yury Semikhatsky 2012-11-01 01:05:09 PDT 
Created attachment 171790 [details]
Patch
Comment 14 WebKit Review Bot 2012-11-01 02:28:40 PDT 
Comment on attachment 171790 [details]
Patch

Clearing flags on attachment: 171790

Committed r133141: <http://trac.webkit.org/changeset/133141>
Comment 15 WebKit Review Bot 2012-11-01 02:28:44 PDT 
All reviewed patches have been landed.  Closing bug.