Bug 100482 - Refactor Localizer-related classes.
Summary: Refactor Localizer-related classes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-26 01:33 PDT by Kent Tamura
Modified: 2012-10-26 07:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.71 KB, patch)
2012-10-26 01:42 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing (13.13 KB, patch)
2012-10-26 03:05 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch for landing 2 (13.17 KB, patch)
2012-10-26 06:28 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-10-26 01:33:09 PDT 
- Localizer has unused code
- Some Localizer subclasses hide Localizer data members
- Should use String::isNull to check initialization-or-not
Comment 1 Kent Tamura 2012-10-26 01:42:58 PDT 
Created attachment 170849 [details]
Patch
Comment 2 Kentaro Hara 2012-10-26 01:51:03 PDT 
Comment on attachment 170849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170849&action=review

> Source/WebCore/platform/text/LocaleNone.cpp:150
> +    if (!m_timeAMPMLabels.isEmpty())

isNull() ?
Comment 3 Kent Tamura 2012-10-26 01:52:30 PDT 
Comment on attachment 170849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170849&action=review

>> Source/WebCore/platform/text/LocaleNone.cpp:150
>> +    if (!m_timeAMPMLabels.isEmpty())
> 
> isNull() ?

No. This is a Vector.
Comment 4 WebKit Review Bot 2012-10-26 03:03:05 PDT 
Comment on attachment 170849 [details]
Patch

Attachment 170849 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14607006
Comment 5 Kent Tamura 2012-10-26 03:05:04 PDT 
Created attachment 170863 [details]
Patch for landing

Fix LocaleICU build
Comment 6 WebKit Review Bot 2012-10-26 03:50:16 PDT 
Comment on attachment 170863 [details]
Patch for landing

Attachment 170863 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14609015
Comment 7 Kent Tamura 2012-10-26 06:28:13 PDT 
Created attachment 170909 [details]
Patch for landing 2
Comment 8 WebKit Review Bot 2012-10-26 07:23:07 PDT 
Comment on attachment 170909 [details]
Patch for landing 2

Clearing flags on attachment: 170909

Committed r132650: <http://trac.webkit.org/changeset/132650>
Comment 9 WebKit Review Bot 2012-10-26 07:23:10 PDT 
All reviewed patches have been landed.  Closing bug.