Bug 100472 – [EFL][WK2] Add Ewk_Color_Picker API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

We should move the color picker code out of EwkView and into a new Ewk_Color_Picker class to avoid cluttering the view code.

[Chris Dumez]

Created attachment 170865 [details]
Patch

[Chris Dumez]

Comment on attachment 170865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170865&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_color_picker.h:61
> +EAPI Eina_Bool ewk_color_picker_color_get(Ewk_Color_Picker *color_picker, int *r, int *g, int *b, int *a);

Oops, argument should be const.

[Chris Dumez]

Created attachment 170867 [details]
Patch for landing

Marked the getter argument as const, as per WebKitEFL coding style. Sorry about that.

Could someone please cq+?

[WebKit Review Bot]

Comment on attachment 170867 [details]
Patch for landing

Rejecting attachment 170867 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
I/efl/ewk_color_picker_private.h
patching file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
patching file Source/WebKit2/UIProcess/API/efl/ewk_view.h
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
patching file Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14566995

[Chris Dumez]

Created attachment 170872 [details]
Patch for landing

Rebased on master.

[WebKit Review Bot]

Comment on attachment 170872 [details]
Patch for landing

Clearing flags on attachment: 170872

Committed r132617: <http://trac.webkit.org/changeset/132617>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.