Bug 100472 - [EFL][WK2] Add Ewk_Color_Picker API
Summary: [EFL][WK2] Add Ewk_Color_Picker API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 100226
  Show dependency tree / graph
 
Reported: 2012-10-26 00:00 PDT by Chris Dumez
Modified: 2012-10-26 04:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (28.67 KB, patch)
2012-10-26 03:11 PDT, Chris Dumez 		kenneth: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (28.70 KB, patch)
2012-10-26 03:23 PDT, Chris Dumez 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (28.76 KB, patch)
2012-10-26 03:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-26 00:00:55 PDT 
We should move the color picker code out of EwkView and into a new Ewk_Color_Picker class to avoid cluttering the view code.
Comment 1 Chris Dumez 2012-10-26 03:11:17 PDT 
Created attachment 170865 [details]
Patch
Comment 2 Chris Dumez 2012-10-26 03:18:45 PDT 
Comment on attachment 170865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170865&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_color_picker.h:61
> +EAPI Eina_Bool ewk_color_picker_color_get(Ewk_Color_Picker *color_picker, int *r, int *g, int *b, int *a);

Oops, argument should be const.
Comment 3 Chris Dumez 2012-10-26 03:23:19 PDT 
Created attachment 170867 [details]
Patch for landing

Marked the getter argument as const, as per WebKitEFL coding style. Sorry about that.

Could someone please cq+?
Comment 4 WebKit Review Bot 2012-10-26 03:25:49 PDT 
Comment on attachment 170867 [details]
Patch for landing

Rejecting attachment 170867 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
I/efl/ewk_color_picker_private.h
patching file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
patching file Source/WebKit2/UIProcess/API/efl/ewk_view.h
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp
patching file Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14566995
Comment 5 Chris Dumez 2012-10-26 03:32:19 PDT 
Created attachment 170872 [details]
Patch for landing

Rebased on master.
Comment 6 WebKit Review Bot 2012-10-26 04:32:40 PDT 
Comment on attachment 170872 [details]
Patch for landing

Clearing flags on attachment: 170872

Committed r132617: <http://trac.webkit.org/changeset/132617>
Comment 7 WebKit Review Bot 2012-10-26 04:32:47 PDT 
All reviewed patches have been landed.  Closing bug.