Bug 100471 – [Chromium-Win] Support shortTimeFormat

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

LocaleWin haven't supported shortTimeFormat(), and it have returned the same format as timeFormat().

[Kent Tamura]

Created attachment 170835 [details]
Patch

[Kent Tamura]

Comment on attachment 170835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170835&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::LocaleWin::shortTimeFormat):
> +        Gets a format by LOCALE_SSHORTTIME. If it fails, remove "<delimiter>ss"
> +        from the format by LOCALE_STIMEFORMAT.

Note that I verified that this algorithm worked well for all supported locales on Windows XP.

[Kentaro Hara]

Comment on attachment 170835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170835&action=review

> Source/WebCore/platform/text/LocaleWin.cpp:709
> +    if (!m_timeFormatWithoutSeconds.isNull())

I'm a bit confused that you're sometimes using isNull() and sometimes isEmpty(). Here m_timeFormatWithoutSeconds can be an Empty string, which is one of valid results, so you are using isNull(), right?

[Kent Tamura]

Comment on attachment 170835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170835&action=review

>> Source/WebCore/platform/text/LocaleWin.cpp:709
>> +    if (!m_timeFormatWithoutSeconds.isNull())
> 
> I'm a bit confused that you're sometimes using isNull() and sometimes isEmpty(). Here m_timeFormatWithoutSeconds can be an Empty string, which is one of valid results, so you are using isNull(), right?

Yeah, isNull is more appropriate than isEmpty in these functions because we'd like to know initialized-or-not.  isEmpty also works well in usual cases, but isNull is faster than isEmpty.

[Kent Tamura]

Committed r132579: <http://trac.webkit.org/changeset/132579>