Bug 100468 - [EFL][WK2] Move input method code out of EwkViewImpl
Summary: [EFL][WK2] Move input method code out of EwkViewImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 100226
  Show dependency treegraph
 
Reported: 2012-10-25 23:35 PDT by Chris Dumez
Modified: 2012-10-26 03:07 PDT (History)
8 users (show)

See Also:


Attachments
Patch (19.34 KB, patch)
2012-10-25 23:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-25 23:35:36 PDT
The input method code is currently in EwkViewImpl but it would be better to create a new class for it, to avoid cluttering the view code.
Comment 1 Chris Dumez 2012-10-25 23:48:33 PDT
Created attachment 170829 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-10-26 01:06:50 PDT
Comment on attachment 170829 [details]
Patch

Do you know whether we have code like Qt (and iOS etc) to only pop up vkb as a result of a user action? Would be great to have (with tests)
Comment 3 WebKit Review Bot 2012-10-26 02:40:38 PDT
Comment on attachment 170829 [details]
Patch

Clearing flags on attachment: 170829

Committed r132594: <http://trac.webkit.org/changeset/132594>
Comment 4 WebKit Review Bot 2012-10-26 02:40:42 PDT
All reviewed patches have been landed.  Closing bug.