Bug 100459 - [Refactoring] Use isActiveInsertionPoint instead of isInsertionPoint
Summary: [Refactoring] Use isActiveInsertionPoint instead of isInsertionPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks: 97279
  Show dependency tree / graph
 
Reported: 2012-10-25 22:13 PDT by Shinya Kawanaka
Modified: 2012-10-29 05:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.79 KB, patch)
2012-10-28 22:14 PDT, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-10-25 22:13:02 PDT 
Basically inert InsertionPoint has no meaning. We don't need to cast it to InsertionPoint.
So it would be good to have isActiveInsertionPoint instead of isInsertionPoint so that we don't miss isActive check.
Comment 1 Shinya Kawanaka 2012-10-28 22:14:27 PDT 
Created attachment 171156 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-29 05:51:48 PDT 
Comment on attachment 171156 [details]
Patch

Clearing flags on attachment: 171156

Committed r132791: <http://trac.webkit.org/changeset/132791>
Comment 3 WebKit Review Bot 2012-10-29 05:51:51 PDT 
All reviewed patches have been landed.  Closing bug.