Bug 100458 - [chromium] Allow embedder to enter/leave force compositing mode
Summary: [chromium] Allow embedder to enter/leave force compositing mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 22:07 PDT by James Robinson
Modified: 2012-10-27 11:02 PDT (History)
8 users (show)

See Also:


Attachments
work in progress (12.15 KB, patch)
2012-10-25 22:08 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2012-10-26 13:14 PDT, James Robinson
no flags Details | Formatted Diff | Diff
With more null checks so it can be called earlier (3.84 KB, patch)
2012-10-26 13:57 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-10-25 22:07:21 PDT
[chromium] Allow embedder to enter/leave force compositing mode
Comment 1 James Robinson 2012-10-25 22:08:22 PDT
Created attachment 170809 [details]
work in progress
Comment 2 James Robinson 2012-10-26 13:14:09 PDT
Created attachment 170989 [details]
Patch
Comment 3 WebKit Review Bot 2012-10-26 13:15:37 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2012-10-26 13:16:53 PDT
After discussing with Enne I think the threaded mode solution will look a bit different and won't involve WebWidget interactions.  This patch will still work fine for the single threaded path.
Comment 5 Adrienne Walker 2012-10-26 13:22:05 PDT
Comment on attachment 170989 [details]
Patch

R=me.
Comment 6 James Robinson 2012-10-26 13:57:05 PDT
Created attachment 170997 [details]
With more null checks so it can be called earlier
Comment 7 Adrienne Walker 2012-10-26 15:06:38 PDT
Comment on attachment 170997 [details]
With more null checks so it can be called earlier

R=meagain.
Comment 8 WebKit Review Bot 2012-10-26 16:03:42 PDT
Comment on attachment 170997 [details]
With more null checks so it can be called earlier

Clearing flags on attachment: 170997

Committed r132708: <http://trac.webkit.org/changeset/132708>
Comment 9 WebKit Review Bot 2012-10-26 16:03:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Roger Fong 2012-10-27 09:23:15 PDT
There are about 15 crashes on each of the bots (Apple-Mac and Apple-Windows) that relate to compositing.

http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29310

It looks like within the regression range that this change is the most relevant. Do you think this could be causing the failures?
Comment 11 Adam Barth 2012-10-27 11:02:23 PDT
> Do you think this could be causing the failures?

This code is not compiled for apple-mac or apple-win.