Bug 100438 - Apply transformation for highlights on non-composited contents
Summary: Apply transformation for highlights on non-composited contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 17:50 PDT by Tien-Ren Chen
Modified: 2012-10-31 15:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.82 KB, patch)
2012-10-25 17:52 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Patch (19.30 KB, patch)
2012-10-30 14:38 PDT, Tien-Ren Chen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2012-10-25 17:50:23 PDT 
Apply transformation for highlights on non-composited contents
Comment 1 Tien-Ren Chen 2012-10-25 17:52:31 PDT 
Created attachment 170773 [details]
Patch
Comment 2 Alexandre Elias 2012-10-25 18:19:32 PDT 
LGTM.  James, Adam?
Comment 3 W. James MacLean 2012-10-26 10:46:44 PDT 
(In reply to comment #2)
> LGTM.  James, Adam?

Sure, looks reasonable to me.
Comment 4 Adam Barth 2012-10-26 14:04:01 PDT 
Comment on attachment 170773 [details]
Patch

Can you test this change?
Comment 5 Adam Barth 2012-10-26 14:04:19 PDT 
As a general rule, changes to WebKit require tests.
Comment 6 Tien-Ren Chen 2012-10-30 14:38:00 PDT 
Created attachment 171522 [details]
Patch
Comment 7 WebKit Review Bot 2012-10-31 15:28:09 PDT 
Comment on attachment 171522 [details]
Patch

Clearing flags on attachment: 171522

Committed r133085: <http://trac.webkit.org/changeset/133085>
Comment 8 WebKit Review Bot 2012-10-31 15:28:13 PDT 
All reviewed patches have been landed.  Closing bug.