Bug 100436 - Build bot gives incorrect link to EWS build failure
Summary: Build bot gives incorrect link to EWS build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 17:12 PDT by Xianzhu Wang
Modified: 2012-10-26 14:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.05 KB, patch)
2012-10-25 18:01 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2012-10-26 10:16 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-10-25 17:12:12 PDT
I met this more than once. The most recent one is in bug 98144 #15:

(From update of attachment 170698 [details])
Attachment 170698 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14555811

New failing tests:
compositing/layer-creation/fixed-position-absolute-descendant.html

The link "http://queues.webkit.org/results/14555811" is incorrect because it doesn't contain any information about the failed test. It seems the result of another patch.

The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct.
Comment 1 Xianzhu Wang 2012-10-25 17:17:18 PDT
(In reply to comment #0)
> The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct.

Actually the link in the message is the build result of:

  Unable to pass tests without patch (tree is red?) [results]

in http://queues.webkit.org/patch/170698 page.

Would be better to give the link to the failure of the patch itself.
Comment 2 Adam Barth 2012-10-25 17:33:43 PDT
Yes, we've had this bug for a while.  The code is in Tools/Scripts/webkitpy if you're interested in fixing it.
Comment 3 Xianzhu Wang 2012-10-25 18:01:13 PDT
Created attachment 170774 [details]
Patch
Comment 4 Adam Barth 2012-10-25 18:10:26 PDT
Comment on attachment 170774 [details]
Patch

Great!  Can you run test-webkitpy to make sure we didn't break any unit tests?  We should also write a unit test for this change.
Comment 5 Ojan Vafai 2012-10-25 18:27:20 PDT
Oh my god! Thanks for fixing this!
Comment 6 Xianzhu Wang 2012-10-25 18:46:56 PDT
test-webkitpy passed.  Will add a unit test tomorrow.
Comment 7 Xianzhu Wang 2012-10-26 10:16:21 PDT
Created attachment 170950 [details]
Patch
Comment 8 Xianzhu Wang 2012-10-26 10:17:04 PDT
Comment on attachment 170950 [details]
Patch

Reusing the existing CommitQueueTaskTest.test_red_tree_patch_rejection as the unit test.
Comment 9 WebKit Review Bot 2012-10-26 11:44:55 PDT
Comment on attachment 170950 [details]
Patch

Clearing flags on attachment: 170950

Committed r132679: <http://trac.webkit.org/changeset/132679>
Comment 10 WebKit Review Bot 2012-10-26 11:45:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Adam Barth 2012-10-26 14:14:06 PDT
Comment on attachment 170950 [details]
Patch

Nice test.  Thank you.