RESOLVED FIXED 100436
Build bot gives incorrect link to EWS build failure 
https://bugs.webkit.org/show_bug.cgi?id=100436
Summary Build bot gives incorrect link to EWS build failure
Xianzhu Wang
Reported 2012-10-25 17:12:12 PDT
I met this more than once. The most recent one is in bug 98144 #15: (From update of attachment 170698 [details]) Attachment 170698 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14555811 New failing tests: compositing/layer-creation/fixed-position-absolute-descendant.html The link "http://queues.webkit.org/results/14555811" is incorrect because it doesn't contain any information about the failed test. It seems the result of another patch. The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct.
Attachments
Patch (2.05 KB, patch)
2012-10-25 18:01 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Patch (3.92 KB, patch)
2012-10-26 10:16 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-10-25 17:17:18 PDT
(In reply to comment #0) > The links in http://queues.webkit.org/patch/170698 (from the EWS bubbles of the patch) are correct. Actually the link in the message is the build result of: Unable to pass tests without patch (tree is red?) [results] in http://queues.webkit.org/patch/170698 page. Would be better to give the link to the failure of the patch itself.
Adam Barth
Comment 2 2012-10-25 17:33:43 PDT
Yes, we've had this bug for a while. The code is in Tools/Scripts/webkitpy if you're interested in fixing it.
Xianzhu Wang
Comment 3 2012-10-25 18:01:13 PDT
Created attachment 170774 [details] Patch
Adam Barth
Comment 4 2012-10-25 18:10:26 PDT
Comment on attachment 170774 [details] Patch Great! Can you run test-webkitpy to make sure we didn't break any unit tests? We should also write a unit test for this change.
Ojan Vafai
Comment 5 2012-10-25 18:27:20 PDT
Oh my god! Thanks for fixing this!
Xianzhu Wang
Comment 6 2012-10-25 18:46:56 PDT
test-webkitpy passed. Will add a unit test tomorrow.
Xianzhu Wang
Comment 7 2012-10-26 10:16:21 PDT
Created attachment 170950 [details] Patch
Xianzhu Wang
Comment 8 2012-10-26 10:17:04 PDT
Comment on attachment 170950 [details] Patch Reusing the existing CommitQueueTaskTest.test_red_tree_patch_rejection as the unit test.
WebKit Review Bot
Comment 9 2012-10-26 11:44:55 PDT
Comment on attachment 170950 [details] Patch Clearing flags on attachment: 170950 Committed r132679: <http://trac.webkit.org/changeset/132679>
WebKit Review Bot
Comment 10 2012-10-26 11:45:00 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 11 2012-10-26 14:14:06 PDT
Comment on attachment 170950 [details] Patch Nice test. Thank you.
Note You need to log in before you can comment on or make changes to this bug.