WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
100431
Optimize KeyframeAnimation to find its timing function.
https://bugs.webkit.org/show_bug.cgi?id=100431
Summary
Optimize KeyframeAnimation to find its timing function.
Dongseong Hwang
Reported
2012-10-25 16:00:25 PDT
Currently, KeyframeAnimation queries its timing function via RenderStyle, but it is not necessary. KeyframeAnimation can get the timing function via its member, Animation.
Attachments
Patch
(2.67 KB, patch)
2012-10-26 01:46 PDT
,
Dongseong Hwang
dongseong.hwang
: review-
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2012-10-26 01:46:17 PDT
Created
attachment 170850
[details]
Patch
Dongseong Hwang
Comment 2
2012-10-26 01:48:53 PDT
This patch removed getAnimationFromStyleByName() that was introduced in
Bug 60303
. This function is correct but slow.
Build Bot
Comment 3
2012-10-26 03:18:39 PDT
Comment on
attachment 170850
[details]
Patch
Attachment 170850
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/14606026
New failing tests: animations/keyframe-timing-functions.html animations/keyframe-timing-functions2.html animations/missing-keyframe-properties-timing-function.html animations/keyframe-timing-functions-transform.html
Dongseong Hwang
Comment 4
2012-10-26 03:36:33 PDT
I misunderstood. The spec said "A keyframe style rule may also declare the timing function that is to be used as the animation moves to the next keyframe."
http://www.w3.org/TR/css3-animations/#timing-functions
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug