RESOLVED FIXED100430
[V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor 
https://bugs.webkit.org/show_bug.cgi?id=100430
Summary [V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor
Adam Barth
Reported 2012-10-25 15:53:01 PDT
[V8] We can merge ActiveDOMObjectPrologueVisitor with ObjectVisitor
Attachments
Patch (4.09 KB, patch)
2012-10-25 15:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-25 15:53:42 PDT
Created attachment 170754 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-25 15:59:26 PDT
Comment on attachment 170754 [details] Patch So this saves a whole walk of the liveObjects?
Adam Barth
Comment 3 2012-10-25 16:04:50 PDT
> So this saves a whole walk of the liveObjects? We don't walk liveObjects. We accumulate liveObjects and then inform V8 about them. This shouldn't have any functional or performance change. We're just doing the walk in with one object rather than two. The eventual goal is to be able to do all the walks at once so we can drive them all from the V8 side.
Eric Seidel (no email)
Comment 4 2012-10-25 16:08:01 PDT
Comment on attachment 170754 [details] Patch Understood. LGTM.
WebKit Review Bot
Comment 5 2012-10-25 20:12:04 PDT
Comment on attachment 170754 [details] Patch Clearing flags on attachment: 170754 Committed r132564: <http://trac.webkit.org/changeset/132564>
WebKit Review Bot
Comment 6 2012-10-25 20:12:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.