RESOLVED FIXED100418
Move SharedWorkerRepository functions out of DefaultSharedWorkerRepository 
https://bugs.webkit.org/show_bug.cgi?id=100418
Summary Move SharedWorkerRepository functions out of DefaultSharedWorkerRepository
Alexey Proskuryakov
Reported 2012-10-25 14:48:54 PDT
...because that's a different class.
Attachments
proposed patch (14.80 KB, patch)
2012-10-25 14:53 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Updated to apply (13.48 KB, patch)
2012-10-25 15:40 PDT, Alexey Proskuryakov 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
with build fix (13.54 KB, patch)
2012-10-25 16:03 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
updated to ToT (13.68 KB, patch)
2013-03-11 15:32 PDT, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
patch for landing (13.69 KB, patch)
2013-03-11 17:28 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-10-25 14:53:58 PDT
Created attachment 170734 [details] proposed patch
Alexey Proskuryakov
Comment 2 2012-10-25 15:40:00 PDT
Created attachment 170747 [details] Updated to apply
Early Warning System Bot
Comment 3 2012-10-25 15:43:02 PDT
Comment on attachment 170747 [details] Updated to apply Attachment 170747 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14563752
Early Warning System Bot
Comment 4 2012-10-25 15:45:23 PDT
Comment on attachment 170747 [details] Updated to apply Attachment 170747 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14545777
Build Bot
Comment 5 2012-10-25 16:00:18 PDT
Comment on attachment 170747 [details] Updated to apply Attachment 170747 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14543831
Alexey Proskuryakov
Comment 6 2012-10-25 16:03:43 PDT
Created attachment 170758 [details] with build fix
WebKit Review Bot
Comment 7 2012-10-25 16:07:27 PDT
Attachment 170758 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/workers/SharedWorkerRepository.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 8 2012-10-26 14:51:04 PDT
Ping reviewers.
Alexey Proskuryakov
Comment 9 2013-03-11 15:32:19 PDT
Created attachment 192577 [details] updated to ToT Updated to ToT.
WebKit Review Bot
Comment 10 2013-03-11 15:35:06 PDT
Attachment 192577 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gyp/WebCore.gyp', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/workers/DefaultSharedWorkerRepository.cpp', u'Source/WebCore/workers/SharedWorkerRepository.cpp']" exit_code: 1 Source/WebCore/workers/SharedWorkerRepository.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 11 2013-03-11 15:36:32 PDT
Comment on attachment 192577 [details] updated to ToT View in context: https://bugs.webkit.org/attachment.cgi?id=192577&action=review > Source/WebCore/workers/SharedWorkerRepository.cpp:35 > +#include "DefaultSharedWorkerRepository.h" > +#include "SharedWorker.h" > +#include "MessagePortChannel.h" SORTING
Alexey Proskuryakov
Comment 12 2013-03-11 17:28:52 PDT
Created attachment 192605 [details] patch for landing
WebKit Review Bot
Comment 13 2013-03-11 19:26:29 PDT
Comment on attachment 192605 [details] patch for landing Clearing flags on attachment: 192605 Committed r145466: <http://trac.webkit.org/changeset/145466>
WebKit Review Bot
Comment 14 2013-03-11 19:26:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.