Bug 100406 - Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
Summary: Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 13:05 PDT by Min Qin
Modified: 2012-10-25 20:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2012-10-25 13:10 PDT, Min Qin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2012-10-25 13:05:12 PDT 
Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
Comment 1 Min Qin 2012-10-25 13:10:07 PDT 
Created attachment 170718 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-25 18:52:55 PDT 
Comment on attachment 170718 [details]
Patch

Rejecting attachment 170718 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14553916
Comment 3 Min Qin 2012-10-25 18:56:00 PDT 
This is wierd, do I also need to modify Source/WebCore/ChangeLog ?
Comment 4 Adam Barth 2012-10-25 18:59:39 PDT 
Comment on attachment 170718 [details]
Patch

Sorry, it's another bug with the bots.  :)
Comment 5 WebKit Review Bot 2012-10-25 20:24:06 PDT 
Comment on attachment 170718 [details]
Patch

Clearing flags on attachment: 170718

Committed r132565: <http://trac.webkit.org/changeset/132565>
Comment 6 WebKit Review Bot 2012-10-25 20:24:10 PDT 
All reviewed patches have been landed.  Closing bug.