Move ImageOrientation transform back in CG space (lower-left origin), adapt the skia code to work with that
Created attachment 170700 [details] Patch
Comment on attachment 170700 [details] Patch (upload error)
Created attachment 170702 [details] Patch
Attachment 170702 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/rendering/RenderObject.cpp:2234: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 170707 [details] Patch
Comment on attachment 170707 [details] Patch Thanks.
Noel: Nico and I discussed on IRC. This patch should bring us "back" to how things worked before Nico started working on this. He said he'd post a patch to show what converting from our current right-handed-system to a left-handed-system would look like.
Comment on attachment 170707 [details] Patch Clearing flags on attachment: 170707 Committed r132525: <http://trac.webkit.org/changeset/132525>
All reviewed patches have been landed. Closing bug.
(In reply to comment #7) > Noel: Nico and I discussed on IRC. This patch should bring us "back" to how things worked before Nico started working on this. He said he'd post a patch to show what converting from our current right-handed-system to a left-handed-system would look like. "back" sounds good. We should also unskip image-orientation-css.html in chromium TestExpectations and start generating its pixel results. We should compare: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp?rev=127170#L47 http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp?rev=127170#L292 and note that one of them mentions orientation! Note: I'm AFK until Tuesday AEST.
(In reply to comment #10) > (In reply to comment #7) > > Noel: Nico and I discussed on IRC. This patch should bring us "back" to how things worked before Nico started working on this. He said he'd post a patch to show what converting from our current right-handed-system to a left-handed-system would look like. > > "back" sounds good. We should also unskip image-orientation-css.html in chromium TestExpectations and start generating its pixel results. I checked in expectations in bug 100434. I'll unskip the test tomorrow. > We should compare: > > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp?rev=127170#L47 > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp?rev=127170#L292 > > and note that one of them mentions orientation! Good catch, uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=100456 (I don't think it makes a difference in practice, see changelog entry in that bug).
(In reply to comment #11) > > > "back" sounds good. We should also unskip image-orientation-css.html in chromium TestExpectations and start generating its pixel results. > > I checked in expectations in bug 100434. I'll unskip the test tomorrow. That's for image-orientation.html. I was asking about "image-orientation-css".html :)
(In reply to comment #11) > > We should compare: > > > > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp?rev=127170#L47 > > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp?rev=127170#L292 > > > > and note that one of them mentions orientation! > > Good catch, uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=100456 (I don't think it makes a difference in practice, see changelog entry in that bug). Ok thanks, added bug 100456 to the chromium orientation meta bug.
(In reply to comment #12) > (In reply to comment #11) > > > > > "back" sounds good. We should also unskip image-orientation-css.html in chromium TestExpectations and start generating its pixel results. > > > > I checked in expectations in bug 100434. I'll unskip the test tomorrow. > > That's for image-orientation.html. I was asking about "image-orientation-css".html :) Oh, I thought that test used the image-orientation css stuff. I'm enabling it in bug 100767, and I'll land baselines for it later today.