Bug 100392 - Move non-Settings Inspector methods from internals.settings to internals
Summary: Move non-Settings Inspector methods from internals.settings to internals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 100393
  Show dependency tree / graph
 
Reported: 2012-10-25 10:13 PDT by Tony Chang
Modified: 2012-10-26 15:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (40.92 KB, patch)
2012-10-25 10:20 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch (46.11 KB, patch)
2012-10-26 13:20 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-10-25 10:13:00 PDT 
Move non-Settings Inspector methods from internals.settings to internals
Comment 1 Tony Chang 2012-10-25 10:20:04 PDT 
Created attachment 170683 [details]
Patch
Comment 2 Tony Chang 2012-10-25 11:04:30 PDT 
See bug 100393 for some additional motivation.
Comment 3 Tony Chang 2012-10-25 14:49:00 PDT 
Comment on attachment 170683 [details]
Patch

Missed some code in InternalSettings::Backup.
Comment 4 Tony Chang 2012-10-26 13:20:16 PDT 
Created attachment 170991 [details]
Patch
Comment 5 Tony Chang 2012-10-26 14:18:07 PDT 
I tried to maintain the existing behavior with this patch.

Note that we don't reset InspectorResourcesDataSizeLimits between tests, but we weren't before this change either (maybe no other test depends on this value?).

Also, it turns out we don't have to disable the profiler between tests because detaching the dev tools agent already does this for us (in InspectorProfilerAgent::clearFrontend).  That said, it seems like that's an implementation detail that could change in the future, and there's no harm in explicitly resetting the state.
Comment 6 WebKit Review Bot 2012-10-26 15:00:12 PDT 
Comment on attachment 170991 [details]
Patch

Clearing flags on attachment: 170991

Committed r132700: <http://trac.webkit.org/changeset/132700>
Comment 7 WebKit Review Bot 2012-10-26 15:00:16 PDT 
All reviewed patches have been landed.  Closing bug.