RESOLVED FIXED100392
Move non-Settings Inspector methods from internals.settings to internals 
https://bugs.webkit.org/show_bug.cgi?id=100392
Summary Move non-Settings Inspector methods from internals.settings to internals
Tony Chang
Reported 2012-10-25 10:13:00 PDT
Move non-Settings Inspector methods from internals.settings to internals
Attachments
Patch (40.92 KB, patch)
2012-10-25 10:20 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (46.11 KB, patch)
2012-10-26 13:20 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-10-25 10:20:04 PDT
Created attachment 170683 [details] Patch
Tony Chang
Comment 2 2012-10-25 11:04:30 PDT
See bug 100393 for some additional motivation.
Tony Chang
Comment 3 2012-10-25 14:49:00 PDT
Comment on attachment 170683 [details] Patch Missed some code in InternalSettings::Backup.
Tony Chang
Comment 4 2012-10-26 13:20:16 PDT
Created attachment 170991 [details] Patch
Tony Chang
Comment 5 2012-10-26 14:18:07 PDT
I tried to maintain the existing behavior with this patch. Note that we don't reset InspectorResourcesDataSizeLimits between tests, but we weren't before this change either (maybe no other test depends on this value?). Also, it turns out we don't have to disable the profiler between tests because detaching the dev tools agent already does this for us (in InspectorProfilerAgent::clearFrontend). That said, it seems like that's an implementation detail that could change in the future, and there's no harm in explicitly resetting the state.
WebKit Review Bot
Comment 6 2012-10-26 15:00:12 PDT
Comment on attachment 170991 [details] Patch Clearing flags on attachment: 170991 Committed r132700: <http://trac.webkit.org/changeset/132700>
WebKit Review Bot
Comment 7 2012-10-26 15:00:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.