Bug 100386 - [Qt] Enable JSC's disassembler on x86, x86_64 Linux
Summary: [Qt] Enable JSC's disassembler on x86, x86_64 Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 09:23 PDT by Gabor Ballabas
Modified: 2012-10-26 03:51 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2012-10-25 09:30 PDT, Gabor Ballabas
hausmann: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Ballabas 2012-10-25 09:23:51 PDT
It works fine on Linux x86, x86_64 just needs to be enabled in the QtWebKit build system.
Comment 1 Gabor Ballabas 2012-10-25 09:30:27 PDT
Created attachment 170671 [details]
Patch
Comment 2 Simon Hausmann 2012-10-26 00:28:47 PDT
Comment on attachment 170671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170671&action=review

LGTM, but I suggest to use an if() before landing.

> Source/JavaScriptCore/DerivedSources.pri:108
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

I suggest to write this as

    linux-*:if(isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64")) {

to be on the very safe side.

> Source/JavaScriptCore/JavaScriptCore.pri:42
> +linux-*:isEqual(QT_ARCH, "i386")|isEqual(QT_ARCH, "x86_64") {

Same here
Comment 3 Kristóf Kosztyó 2012-10-26 03:51:26 PDT
Committed r132606: <http://trac.webkit.org/changeset/132606>