Bug 100383 - [WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout
Summary: [WK2] Enable delegate scrolling as soon as the FrameView is created if we're ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on: 100900
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-25 08:29 PDT by Jocelyn Turcotte
Modified: 2012-11-01 08:19 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.89 KB, patch)
2012-10-25 09:02 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2012-11-01 08:01 PDT, Jocelyn Turcotte
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2012-10-25 08:29:40 PDT
[WK2] Enable delegate scrolling as soon as the FrameView is created if we're using fixed layout
Comment 1 Jocelyn Turcotte 2012-10-25 09:02:15 PDT
Created attachment 170664 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-29 03:28:18 PDT
Comment on attachment 170664 [details]
Patch

Clearing flags on attachment: 170664

Committed r132780: <http://trac.webkit.org/changeset/132780>
Comment 3 WebKit Review Bot 2012-10-29 03:28:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Beth Dakin 2012-10-31 15:13:54 PDT
This introduced some undesired behavior on Mac. The call to:

    m_page->settings()->setAcceleratedCompositingForFixedPositionEnabled(fixed);

is not right for Mac.
Comment 5 Simon Fraser (smfr) 2012-10-31 15:14:58 PDT
Should that code only run if delegated scrolling is being used?
Comment 6 WebKit Review Bot 2012-10-31 16:20:07 PDT
Re-opened since this is blocked by bug 100900
Comment 7 Jocelyn Turcotte 2012-11-01 08:01:04 PDT
Created attachment 171853 [details]
Patch

Since the rollout hasn't been landed yet I'm uploading a fix here directly.
It is quite wrong to allow those settings to be set to false in every case.
Comment 8 Jocelyn Turcotte 2012-11-01 08:19:38 PDT
Committed r133176: <http://trac.webkit.org/changeset/133176>