Bug 100360 - [Qt] REGRESSION(r128174): Fast build path doesn't work now
Summary: [Qt] REGRESSION(r128174): Fast build path doesn't work now
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: All All
: P1 Critical
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-10-25 03:52 PDT by Csaba Osztrogonác
Modified: 2012-11-20 06:12 PST (History)
6 users (show)

See Also:

Attachments
build log on Debian Squeeze (58.89 KB, text/plain)
2012-10-25 04:08 PDT, Csaba Osztrogonác 		no flags Details
build log on Ubuntu 11.10 (57.47 KB, text/plain)
2012-10-25 04:37 PDT, Csaba Osztrogonác 		no flags Details
Patch (2.19 KB, patch)
2012-11-20 06:01 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-10-25 03:52:10 PDT 
It seems fast build path triggered by build-webkit doesn't work.
When qmake isn't called at all, only make to avoid ~1.5-2 minutes
runtime of qmake.

I'll attach build logs soon.
Comment 1 Csaba Osztrogonác 2012-10-25 04:08:52 PDT 
Created attachment 170606 [details]
build log on Debian Squeeze

It seems build-webkit calls simple make, but somehow make calls qmake too always.
Comment 2 Csaba Osztrogonác 2012-10-25 04:37:14 PDT 
Created attachment 170615 [details]
build log on Ubuntu 11.10
Comment 3 Csaba Osztrogonác 2012-10-25 04:37:52 PDT 
Tor Arne, have you got any idea what happens here?
Comment 4 Tor Arne Vestbø 2012-10-25 04:57:59 PDT 
(In reply to comment #0)
> It seems fast build path triggered by build-webkit doesn't work.

Fast path? 

> When qmake isn't called at all, only make to avoid ~1.5-2 minutes
> runtime of qmake.

I can't parse this :)
Comment 5 Csaba Osztrogonác 2012-10-25 05:01:03 PDT 
There are 3 different path:
- make (only make called)
- make incremental (qmake and make called)
- make wipeclean && make incremental

I meant the first one which doesn't work now.
See the logs, qmake always run, but it shouldn't.
Comment 6 Csaba Osztrogonác 2012-11-04 00:51:08 PDT 
ping?
Comment 7 Tor Arne Vestbø 2012-11-05 01:40:56 PST 
(In reply to comment #5)
> There are 3 different path:
> - make (only make called)
> - make incremental (qmake and make called)
> - make wipeclean && make incremental
> 
> I meant the first one which doesn't work now.
> See the logs, qmake always run, but it shouldn't.

I'll have a look.
Comment 8 Csaba Osztrogonác 2012-11-20 05:28:06 PST 
We checked it with dicska and determined that r128174 is the culprit.

The problem in nutshell: the SVN revision of last success build is appended 
at the end of WebKitBuild/Relase/.qmake.cache after the build is finished.
But _all_ makefiles depends on .qmake.cache and this dependency triggers
run qmake / regenerate makefiles _always_, because .qmake.cache is _always_
newer than any makefile.

Previously WebKitBuild/Relase/.webkit.config contained the SVN revision
which isn't dependency of any makefile. And .qmake.cache - dependency of
all makefile - wasn't updated always.

Any idea how to fix it?
Comment 9 Csaba Osztrogonác 2012-11-20 05:29:35 PST 
r128174 - http://trac.webkit.org/changeset/128174 - This revision got rid .webkit.config / merge it to .qmake.cache.
Comment 10 Csaba Osztrogonác 2012-11-20 06:01:47 PST 
Created attachment 175199 [details]
Patch
Comment 11 Tor Arne Vestbø 2012-11-20 06:06:39 PST 
Comment on attachment 175199 [details]
Patch

Ouch. Yeah, this is probably the best option.
Comment 12 Csaba Osztrogonác 2012-11-20 06:12:39 PST 
Comment on attachment 175199 [details]
Patch

Clearing flags on attachment: 175199

Committed r135275: <http://trac.webkit.org/changeset/135275>
Comment 13 Csaba Osztrogonác 2012-11-20 06:12:45 PST 
All reviewed patches have been landed.  Closing bug.