Bug 100356 - Conditionalize XHR timeout support
Summary: Conditionalize XHR timeout support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 01:57 PDT by Dominik Röttsches (drott)
Modified: 2012-10-26 04:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (40.29 KB, patch)
2012-10-25 06:45 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-10-25 01:57:25 PDT 
abarth has asked to conditionalize xhr timeout support for ports that don't support it so that feature detection on web sites works.
Comment 1 Kenneth Rohde Christiansen 2012-10-25 06:04:58 PDT 
Link to spec?
Comment 2 Dominik Röttsches (drott) 2012-10-25 06:18:28 PDT 
http://www.w3.org/TR/XMLHttpRequest/#the-timeout-attribute

Implementation was discussed already and landed in bug 74802.
Comment 3 Dominik Röttsches (drott) 2012-10-25 06:45:10 PDT 
Created attachment 170630 [details]
Patch
Comment 4 Adam Barth 2012-10-25 10:45:59 PDT 
Comment on attachment 170630 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-10-25 12:27:01 PDT 
Comment on attachment 170630 [details]
Patch

Clearing flags on attachment: 170630

Committed r132513: <http://trac.webkit.org/changeset/132513>
Comment 6 WebKit Review Bot 2012-10-25 12:27:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Kent Tamura 2012-10-25 19:17:54 PDT 
Would you update http://trac.webkit.org/wiki/FeatureFlags please?
Comment 8 Dominik Röttsches (drott) 2012-10-26 04:02:33 PDT 
(In reply to comment #7)
> Would you update http://trac.webkit.org/wiki/FeatureFlags please?

Done, https://trac.webkit.org/wiki/FeatureFlags#XHR_TIMEOUT