Bug 100355 - Allow LoaderStrategy to override the ResourceLoadScheduler
Summary: Allow LoaderStrategy to override the ResourceLoadScheduler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 98539
  Show dependency tree / graph
 
Reported: 2012-10-25 01:52 PDT by Brady Eidson
Modified: 2012-10-25 10:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 - Get the EWS ball rolling (32.65 KB, patch)
2012-10-25 02:07 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 - Applies? (32.68 KB, patch)
2012-10-25 09:07 PDT, Brady Eidson 		andersca: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch v3 - Fix non NETWORK_PROCESS builds. (32.70 KB, patch)
2012-10-25 09:15 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-10-25 01:52:49 PDT 
Allow LoaderStrategy to override the ResourceLoadScheduler

This will include a default implementation that returns the current WebCore ResourceLoadScheduler.
It will also include a WebKit2 implementation of a WebResourceLoadScheduler that doesn't do anything differently (yet)
Comment 1 Brady Eidson 2012-10-25 02:07:21 PDT 
Created attachment 170591 [details]
Patch v1 - Get the EWS ball rolling
Comment 2 Brady Eidson 2012-10-25 09:07:07 PDT 
Created attachment 170666 [details]
Patch v2 - Applies?
Comment 3 WebKit Review Bot 2012-10-25 09:10:45 PDT 
Attachment 170666 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/loader/cache/CachedResourceLoader.cpp:50:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:25:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2012-10-25 09:12:07 PDT 
Comment on attachment 170666 [details]
Patch v2 - Applies?

Attachment 170666 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14554681
Comment 5 Brady Eidson 2012-10-25 09:15:58 PDT 
Created attachment 170668 [details]
Patch v3 - Fix non NETWORK_PROCESS builds.
Comment 6 Brady Eidson 2012-10-25 09:57:08 PDT 
EWS bots are way behind this morning...  I'll wait on a couple more.
Comment 7 Brady Eidson 2012-10-25 10:17:06 PDT 
http://trac.webkit.org/changeset/132501