Bug 100343 - AX: file upload input cannot be activated with VoiceOver
Summary: AX: file upload input cannot be activated with VoiceOver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-25 00:23 PDT by chris fleizach
Modified: 2012-11-25 22:08 PST (History)
8 users (show)

See Also:


Attachments
patch (6.07 KB, patch)
2012-10-25 22:21 PDT, chris fleizach
sam: review-
Details | Formatted Diff | Diff
patch (4.27 KB, patch)
2012-11-15 17:51 PST, chris fleizach
sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2012-10-25 00:23:06 PDT
AXPress as an action does not activate file upload input controls
Comment 1 chris fleizach 2012-10-25 00:23:17 PDT
rdar://11400485
Comment 2 chris fleizach 2012-10-25 22:21:16 PDT
Created attachment 170812 [details]
patch
Comment 3 Sam Weinig 2012-11-13 13:02:48 PST
Comment on attachment 170812 [details]
patch

I don't think this is the right approach.  Instead, we note that we are processing a user event when we enter the part of the accessibility code that will fire the click.  That could either be in [WebAccessibilityObjectWrapper accessibilityPerformPressAction] or maybe AccessibilityObject::press() and the derived versions.  You can use the UserGestureIndicator class to set the state.
Comment 4 chris fleizach 2012-11-15 17:51:21 PST
Created attachment 174576 [details]
patch
Comment 5 chris fleizach 2012-11-15 17:52:10 PST
Sam, could you take another look.
Thanks
Comment 6 Build Bot 2012-11-16 16:45:42 PST
Comment on attachment 174576 [details]
patch

Attachment 174576 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14859547

New failing tests:
inspector-protocol/nmi-webaudio.html
Comment 7 Sam Weinig 2012-11-19 17:54:30 PST
Thanks for tackling this Chris.
Comment 8 chris fleizach 2012-11-25 22:08:44 PST
http://trac.webkit.org/changeset/135680