There is below assertion after r132386 when dispatching ipc message about DownloadProxy. ASSERTION FAILED: !decoder.destinationID() /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp(79) : bool CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) To fix the assertion problem, adding/removing messageReceiver for DownloadProxy need to use new addMessageReceiver() function with downloadID for destinationID parameter.
Created attachment 170569 [details] Patch
Comment on attachment 170569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > Source/WebKit2/ChangeLog:8 > + Per destination ID message receivers are proposed at r132386. in r... not at > Source/WebKit2/ChangeLog:10 > + so the messages should be handled by per destination ID message receivers. by per sounds weird. by?
(In reply to comment #2) > (From update of attachment 170569 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > > > Source/WebKit2/ChangeLog:8 > > + Per destination ID message receivers are proposed at r132386. > > in r... not at Ok. I'll change it. > > > Source/WebKit2/ChangeLog:10 > > + so the messages should be handled by per destination ID message receivers. > > by per sounds weird. by? How about this? 'so the messages should be handled by the message receivers that is newly proposed.'
Comment on attachment 170569 [details] Patch Looks reasonable to me but it would be nice if Andersca took a look.
Created attachment 170598 [details] Patch
Applied the comments from kenneth.
Comment on attachment 170598 [details] Patch Looks great! r=me.
Comment on attachment 170598 [details] Patch Thank you for the review :)
Comment on attachment 170598 [details] Patch Clearing flags on attachment: 170598 Committed r132548: <http://trac.webkit.org/changeset/132548>
All reviewed patches have been landed. Closing bug.