RESOLVED FIXED 100333
[V8] DOMDataStoreHandle serves no purpose and can be removed 
https://bugs.webkit.org/show_bug.cgi?id=100333
Summary [V8] DOMDataStoreHandle serves no purpose and can be removed
Adam Barth
Reported 2012-10-24 23:06:33 PDT
[V8] DOMDataStoreHandle serves no purpose and can be removed
Attachments
Patch (4.07 KB, patch)
2012-10-24 23:07 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-10-24 23:07:17 PDT
Created attachment 170554 [details] Patch
Eric Seidel (no email)
Comment 2 2012-10-24 23:19:35 PDT
Comment on attachment 170554 [details] Patch LGTM.
Eric Seidel (no email)
Comment 3 2012-10-24 23:20:08 PDT
Comment on attachment 170554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89 > + m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld)); is adoptPtr necessary for OwnPtrs?
Adam Barth
Comment 4 2012-10-24 23:29:43 PDT
(In reply to comment #3) > (From update of attachment 170554 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review > > > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89 > > + m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld)); > > is adoptPtr necessary for OwnPtrs? Yes. That's a result of the "strict OwnPtr" work from a year or so ago.
WebKit Review Bot
Comment 5 2012-10-25 01:15:15 PDT
Comment on attachment 170554 [details] Patch Clearing flags on attachment: 170554 Committed r132458: <http://trac.webkit.org/changeset/132458>
WebKit Review Bot
Comment 6 2012-10-25 01:15:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.