Bug 100333 - [V8] DOMDataStoreHandle serves no purpose and can be removed
Summary: [V8] DOMDataStoreHandle serves no purpose and can be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 100316
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-24 23:06 PDT by Adam Barth
Modified: 2012-10-25 01:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2012-10-24 23:07 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-24 23:06:33 PDT 
[V8] DOMDataStoreHandle serves no purpose and can be removed
Comment 1 Adam Barth 2012-10-24 23:07:17 PDT 
Created attachment 170554 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-24 23:19:35 PDT 
Comment on attachment 170554 [details]
Patch

LGTM.
Comment 3 Eric Seidel (no email) 2012-10-24 23:20:08 PDT 
Comment on attachment 170554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));

is adoptPtr necessary for OwnPtrs?
Comment 4 Adam Barth 2012-10-24 23:29:43 PDT 
(In reply to comment #3)
> (From update of attachment 170554 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170554&action=review
> 
> > Source/WebCore/bindings/v8/DOMWrapperWorld.h:89
> > +            m_domDataStore = adoptPtr(new DOMDataStore(DOMDataStore::IsolatedWorld));
> 
> is adoptPtr necessary for OwnPtrs?

Yes.  That's a result of the "strict OwnPtr" work from a year or so ago.
Comment 5 WebKit Review Bot 2012-10-25 01:15:15 PDT 
Comment on attachment 170554 [details]
Patch

Clearing flags on attachment: 170554

Committed r132458: <http://trac.webkit.org/changeset/132458>
Comment 6 WebKit Review Bot 2012-10-25 01:15:19 PDT 
All reviewed patches have been landed.  Closing bug.