Bug 100318 - [Texmap] Enable filter animations in GraphicsLayerAnimation
Summary: [Texmap] Enable filter animations in GraphicsLayerAnimation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 18:29 PDT by Noam Rosenthal
Modified: 2012-10-31 11:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.80 KB, patch)
2012-10-24 18:40 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-10-24 18:29:27 PDT
[Texmap] Enable filter animations in GraphicsLayerAnimation
Comment 1 Noam Rosenthal 2012-10-24 18:40:25 PDT
Created attachment 170534 [details]
Patch
Comment 2 Dongseong Hwang 2012-10-24 21:31:00 PDT
Comment on attachment 170534 [details]
Patch

Great! I'm waiting this patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=170534&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:123
> +    void setFilters(const FilterOperations& filters) { m_filters = filters; }

setFilters rhymes with setTransform and setOpacity. qwebframe and LayerTreeRenderer needs setTransform and setOpacity but I think setFilters is used by only setAnimatedFilters forever.
Comment 3 WebKit Review Bot 2012-10-31 11:06:28 PDT
Comment on attachment 170534 [details]
Patch

Clearing flags on attachment: 170534

Committed r133047: <http://trac.webkit.org/changeset/133047>
Comment 4 WebKit Review Bot 2012-10-31 11:06:33 PDT
All reviewed patches have been landed.  Closing bug.