Bug 100313 - [V8] DOMData is no longer needed
Summary: [V8] DOMData is no longer needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 100175
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-24 17:33 PDT by Adam Barth
Modified: 2012-10-24 23:07 PDT (History)
2 users (show)

See Also:


Attachments
Patch (16.20 KB, patch)
2012-10-24 17:46 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (16.22 KB, patch)
2012-10-24 22:03 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-24 17:33:50 PDT
[V8] DOMData is no longer needed
Comment 1 Adam Barth 2012-10-24 17:46:32 PDT
Created attachment 170524 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-10-24 18:17:26 PDT
Comment on attachment 170524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170524&action=review

LGTM.

> Source/WebCore/bindings/v8/V8DOMMap.cpp:91
> +    DOMDataStore* store = DOMDataStore::from(v8::Isolate::GetCurrent());

This pattern is confusing to me.  It's unclear who owns the object.  Perhaps sharedInstanceFor?  or lookupForInstance?  or even just changing it back to a reference makes it clear that the caller isn't responsible for the memory (or handling null!)
Comment 3 Adam Barth 2012-10-24 22:03:07 PDT
Created attachment 170548 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-10-24 23:07:09 PDT
Comment on attachment 170548 [details]
Patch for landing

Clearing flags on attachment: 170548

Committed r132447: <http://trac.webkit.org/changeset/132447>
Comment 5 WebKit Review Bot 2012-10-24 23:07:13 PDT
All reviewed patches have been landed.  Closing bug.