Bug 100308 - Fix issues with filters and reflections
Summary: Fix issues with filters and reflections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-24 16:29 PDT by Simon Fraser (smfr)
Modified: 2013-01-16 22:49 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.20 KB, patch)
2012-10-24 16:32 PDT, Simon Fraser (smfr) 		krit: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-10-24 16:29:15 PDT 
Fix issues with filters and reflections
Comment 1 Simon Fraser (smfr) 2012-10-24 16:32:35 PDT 
Created attachment 170507 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-24 18:49:57 PDT 
Comment on attachment 170507 [details]
Patch

Attachment 170507 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14554469

New failing tests:
css3/filters/composited-reflected.html
Comment 3 Dirk Schulze 2012-10-26 00:08:21 PDT 
Comment on attachment 170507 [details]
Patch

LGTM. Please add your test to the TestExpectation files before landing.
Comment 4 Simon Fraser (smfr) 2012-10-30 22:04:34 PDT 
http://trac.webkit.org/changeset/132982
Comment 5 Tim Horton 2013-01-16 02:58:27 PST 
Comment on attachment 170507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> +    newLayer->copyFiltersFrom(layer);

This needed an #if ENABLE(CSS_FILTERS) :D
Comment 6 Dirk Schulze 2013-01-16 22:46:10 PST 
(In reply to comment #5)
> (From update of attachment 170507 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review
> 
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> > +    newLayer->copyFiltersFrom(layer);
> 
> This needed an #if ENABLE(CSS_FILTERS) :D

Did you fixed it already? Can you open a new bug if not please?
Comment 7 Tim Horton 2013-01-16 22:49:07 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 170507 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review
> > 
> > > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> > > +    newLayer->copyFiltersFrom(layer);
> > 
> > This needed an #if ENABLE(CSS_FILTERS) :D
> 
> Did you fixed it already? Can you open a new bug if not please?

I did, in http://trac.webkit.org/changeset/139903. There are two more things broken, I'll post a patch for them shortly.