Bug 100308 – Fix issues with filters and reflections

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Fix issues with filters and reflections

[Simon Fraser (smfr)]

Created attachment 170507 [details]
Patch

[WebKit Review Bot]

Comment on attachment 170507 [details]
Patch

Attachment 170507 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14554469

New failing tests:
css3/filters/composited-reflected.html

[Dirk Schulze]

Comment on attachment 170507 [details]
Patch

LGTM. Please add your test to the TestExpectation files before landing.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/132982

[Tim Horton]

Comment on attachment 170507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> +    newLayer->copyFiltersFrom(layer);

This needed an #if ENABLE(CSS_FILTERS) :D

[Dirk Schulze]

(In reply to comment #5)
> (From update of attachment 170507 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review
> 
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> > +    newLayer->copyFiltersFrom(layer);
> 
> This needed an #if ENABLE(CSS_FILTERS) :D

Did you fixed it already? Can you open a new bug if not please?

[Tim Horton]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 170507 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=170507&action=review
> > 
> > > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2830
> > > +    newLayer->copyFiltersFrom(layer);
> > 
> > This needed an #if ENABLE(CSS_FILTERS) :D
> 
> Did you fixed it already? Can you open a new bug if not please?

I did, in http://trac.webkit.org/changeset/139903. There are two more things broken, I'll post a patch for them shortly.