Bug 100303 – [EFL] Fix failure to highlight nodes on web inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Seokju Kwon]

It is not working to highlight nodes on web inspector when webview has SBS(Single Backing Store).

[Seokju Kwon]

Created attachment 170522 [details]
Patch

[Ryuan Choi]

Comment on attachment 170522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170522&action=review

> Source/WebKit/efl/ewk/ewk_paint_context.cpp:172
> +#if ENABLE(INSPECTOR)
> +    WebCore::Page* page = view->frame()->page();
> +    if (page) {
> +        WebCore::InspectorController* controller = page->inspectorController();
> +        if (controller->highlightedNode())
> +            controller->drawHighlight(*context->graphicContext);
> +    }
> +#endif

SBS calls ewk_paint_context many times for every dirty rect.

How about moving this into ewk_view_single to call only one time.

[Seokju Kwon]

(In reply to comment #2)
> (From update of attachment 170522 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170522&action=review
> 
> > Source/WebKit/efl/ewk/ewk_paint_context.cpp:172
> > +#if ENABLE(INSPECTOR)
> > +    WebCore::Page* page = view->frame()->page();
> > +    if (page) {
> > +        WebCore::InspectorController* controller = page->inspectorController();
> > +        if (controller->highlightedNode())
> > +            controller->drawHighlight(*context->graphicContext);
> > +    }
> > +#endif
> 
> SBS calls ewk_paint_context many times for every dirty rect.
> 
> How about moving this into ewk_view_single to call only one time.

Ok. I will move it.

[Seokju Kwon]

Created attachment 170836 [details]
Patch

[Ryuan Choi]

(In reply to comment #4)
> Created an attachment (id=170836) [details]
> Patch

LGTM.

[Gyuyoung Kim]

Comment on attachment 170836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review

> Source/WebKit/efl/ewk/ewk_view_single.cpp:276
> +    if (page) {

WebKit prefers to use early return.

[Gyuyoung Kim]

Comment on attachment 170836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170836&action=review

>> Source/WebKit/efl/ewk/ewk_view_single.cpp:276
>> +    if (page) {
> 
> WebKit prefers to use early return.

As we talk in private, we can't return early in this case. If we do early return, remaining functions won't be called.

[WebKit Review Bot]

Comment on attachment 170836 [details]
Patch

Clearing flags on attachment: 170836

Committed r132987: <http://trac.webkit.org/changeset/132987>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.