Bug 100300 – Remove the circular reference between TextTrack and TextTrackCue

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Aaron Colwell]

Remove the circular reference between TextTrack and TextTrackCue

[Aaron Colwell]

Created attachment 170497 [details]
Patch

[Aaron Colwell]

Created attachment 170509 [details]
Removed fprintf() accidentally left in the previous patch.

[Eric Carlson]

Comment on attachment 170509 [details]
Removed fprintf() accidentally left in the previous patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=170509&action=review

> Source/WebCore/ChangeLog:8
> +        Changed TextTrackCue.m_track to a normal pointer to break the circular reference that was keeping both objects from ever getting deleted.

Nit: this would be easier to read if the line was wrapped.

> Source/WebCore/html/track/TextTrack.cpp:120
> +        for (size_t i = 0; i < m_cues->length(); ++i)
> +            m_cues->item(i)->setTrack(0);
> +
> +        if (m_client)
> +            m_client->textTrackRemoveCues(this, m_cues.get());

This should call textTrackRemoveCues before setTrack(0) because the client may need the cue's Track.

[Aaron Colwell]

Created attachment 170965 [details]
Addressed CR comments

[WebKit Review Bot]

Comment on attachment 170965 [details]
Addressed CR comments

Clearing flags on attachment: 170965

Committed r132681: <http://trac.webkit.org/changeset/132681>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.