Bug 100295 - [V8] WorkerContextExecutionProxy doesn't need to track events
Summary: [V8] WorkerContextExecutionProxy doesn't need to track events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 100175
  Show dependency treegraph
 
Reported: 2012-10-24 15:20 PDT by Adam Barth
Modified: 2012-10-24 16:17 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.52 KB, patch)
2012-10-24 15:21 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-24 15:20:02 PDT
[V8] WorkerContextExecutionProxy doesn't need to track events
Comment 1 Eric Seidel (no email) 2012-10-24 15:20:43 PDT
His patch may explain some set of our crash-on-shutdown bugs.
Comment 2 Adam Barth 2012-10-24 15:21:52 PDT
Created attachment 170484 [details]
Patch
Comment 3 Adam Barth 2012-10-24 15:23:34 PDT
/cc the author and reviewer of http://trac.webkit.org/changeset/41862
Comment 4 Abhishek Arya 2012-10-24 15:27:27 PDT
Nice catch. I just did a search for "Vector<Event*" across our codebase and this seems like the only place left.
Comment 5 WebKit Review Bot 2012-10-24 16:17:48 PDT
Comment on attachment 170484 [details]
Patch

Clearing flags on attachment: 170484

Committed r132417: <http://trac.webkit.org/changeset/132417>
Comment 6 WebKit Review Bot 2012-10-24 16:17:51 PDT
All reviewed patches have been landed.  Closing bug.